Re: [Intel-gfx] [PATCH 04/10] [v2] drm/i915: Don't touch South Display when PCH_NOP

2013-03-18 Thread Ben Widawsky
On Sun, Mar 17, 2013 at 10:21:30PM +0100, Daniel Vetter wrote: > On Thu, Mar 14, 2013 at 08:55:16AM -0700, Ben Widawsky wrote: > > Interrupts, clock gating, and GMBUS are all within the, "this will hang > > the CPU" range when we have PCH_NOP. > > > > There is a bit of a hack in init clock gating.

Re: [Intel-gfx] [PATCH 04/10] [v2] drm/i915: Don't touch South Display when PCH_NOP

2013-03-17 Thread Daniel Vetter
On Thu, Mar 14, 2013 at 08:55:16AM -0700, Ben Widawsky wrote: > Interrupts, clock gating, and GMBUS are all within the, "this will hang > the CPU" range when we have PCH_NOP. > > There is a bit of a hack in init clock gating. We want to do most of the > clock gating, but the part we skip will hang

[Intel-gfx] [PATCH 04/10] [v2] drm/i915: Don't touch South Display when PCH_NOP

2013-03-15 Thread Ben Widawsky
Interrupts, clock gating, and GMBUS are all within the, "this will hang the CPU" range when we have PCH_NOP. There is a bit of a hack in init clock gating. We want to do most of the clock gating, but the part we skip will hang the system. It could probably be abstracted a bit better, but I don't f

[Intel-gfx] [PATCH 04/10] [v2] drm/i915: Don't touch South Display when PCH_NOP

2013-03-14 Thread Ben Widawsky
Interrupts, clock gating, and GMBUS are all within the, "this will hang the CPU" range when we have PCH_NOP. There is a bit of a hack in init clock gating. We want to do most of the clock gating, but the part we skip will hang the system. It could probably be abstracted a bit better, but I don't f