Re: [Intel-gfx] [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions

2015-03-25 Thread Konduru, Chandra
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, March 24, 2015 10:14 PM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org; Vetter, Daniel; Conselvan De Oliveira, > Ander > Subject: Re: [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions > > On Fri,

Re: [Intel-gfx] [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions

2015-03-25 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 10:13:54PM -0700, Matt Roper wrote: > On Fri, Mar 20, 2015 at 05:04:25PM -0700, Chandra Konduru wrote: > > +struct intel_scaler { > > + int id; > > + int in_use; > > + uint32_t mode; > > If I'm reading later patches correctly, this looks like this is always > PS_SCALE

Re: [Intel-gfx] [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions

2015-03-24 Thread Matt Roper
On Fri, Mar 20, 2015 at 05:04:25PM -0700, Chandra Konduru wrote: > skylake scaler structure definitions. scalers live in crtc_state as > they are pipe resources. They can be used either as plane scaler or > panel fitter. > > scaler assigned to either plane (for plane scaling) or crtc (for panel >

[Intel-gfx] [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions

2015-03-20 Thread Chandra Konduru
skylake scaler structure definitions. scalers live in crtc_state as they are pipe resources. They can be used either as plane scaler or panel fitter. scaler assigned to either plane (for plane scaling) or crtc (for panel fitting) is saved in scaler_id in plane_state or crtc_state respectively. sc