Re: [Intel-gfx] [PATCH 05/11] drm/i915: simplify wm->is_planar assignment

2018-10-18 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 03:01:27PM -0700, Paulo Zanoni wrote: > We're currently doing it in two different ways, none of them based on > the wm_params struct. Both places are correct, so I chose to keep the > one in skl_compute_wm_levels() since it's the function that sets the > other values for the

[Intel-gfx] [PATCH 05/11] drm/i915: simplify wm->is_planar assignment

2018-10-16 Thread Paulo Zanoni
We're currently doing it in two different ways, none of them based on the wm_params struct. Both places are correct, so I chose to keep the one in skl_compute_wm_levels() since it's the function that sets the other values for the same struct. But I'm open to better suggestions on the place to assig