On Fri, 19 Apr 2013 11:24:37 +0200
Daniel Vetter wrote:
> + pipeconf &= ~(PIPECONF_BPC_MASK | PIPECONF_DITHER_EN);
> + if (intel_crtc->config.dither && intel_crtc->config.pipe_bpp !=
> 30)
I think the magic != 30 check needs a comment, or we should never
set .dither for
The current code is rather ... ugly. The only thing it managed to pull
off is getting 6bpc on DP working on g4x. Then someone added another
custom hack for 6bpc eDP on vlv. Fix up this entire mess by properly
implementing the PIPECONF-based dither/bpc controls on g4x/vlv.
Note that compared to pch