[Intel-gfx] [PATCH 05/20] drm/i915: Cancel reset-engine if we couldn't find an active request

2017-05-15 Thread Michel Thierry
Before reseting an engine, check if there is an active request, and if the _hung_ request has completed. In these two cases, the seqno has moved after hang declaration and we can skip the reset. Also store the active request so that we only search for it once. v2: Check for request completion ins

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Cancel reset-engine if we couldn't find an active request

2017-05-15 Thread Chris Wilson
On Mon, May 15, 2017 at 02:20:01PM -0700, Michel Thierry wrote: > @@ -2827,21 +2830,34 @@ int i915_gem_reset_prepare_engine(struct > intel_engine_cs *engine) > > if (engine_stalled(engine)) { > request = i915_gem_find_active_request(engine); > - if (request && req

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Cancel reset-engine if we couldn't find an active request

2017-05-15 Thread Chris Wilson
On Mon, May 15, 2017 at 10:31:58PM +0100, Chris Wilson wrote: > On Mon, May 15, 2017 at 02:20:01PM -0700, Michel Thierry wrote: > > @@ -2827,21 +2830,34 @@ int i915_gem_reset_prepare_engine(struct > > intel_engine_cs *engine) > > > > if (engine_stalled(engine)) { > > request = i9

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Cancel reset-engine if we couldn't find an active request

2017-05-15 Thread Michel Thierry
On 5/15/2017 2:47 PM, Chris Wilson wrote: On Mon, May 15, 2017 at 10:31:58PM +0100, Chris Wilson wrote: On Mon, May 15, 2017 at 02:20:01PM -0700, Michel Thierry wrote: @@ -2827,21 +2830,34 @@ int i915_gem_reset_prepare_engine(struct intel_engine_cs *engine) if (engine_stalled(engine))

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Cancel reset-engine if we couldn't find an active request

2017-05-16 Thread Chris Wilson
On Mon, May 15, 2017 at 03:25:27PM -0700, Michel Thierry wrote: > On 5/15/2017 2:47 PM, Chris Wilson wrote: > >On Mon, May 15, 2017 at 10:31:58PM +0100, Chris Wilson wrote: > >>On Mon, May 15, 2017 at 02:20:01PM -0700, Michel Thierry wrote: > >>>@@ -2827,21 +2830,34 @@ int i915_gem_reset_prepare_en

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Cancel reset-engine if we couldn't find an active request

2017-05-16 Thread Michel Thierry
On 16/05/17 00:54, Chris Wilson wrote: On Mon, May 15, 2017 at 03:25:27PM -0700, Michel Thierry wrote: On 5/15/2017 2:47 PM, Chris Wilson wrote: On Mon, May 15, 2017 at 10:31:58PM +0100, Chris Wilson wrote: On Mon, May 15, 2017 at 02:20:01PM -0700, Michel Thierry wrote: @@ -2827,21 +2830,34 @

Re: [Intel-gfx] [PATCH 05/20] drm/i915: Cancel reset-engine if we couldn't find an active request

2017-05-17 Thread Chris Wilson
On Tue, May 16, 2017 at 05:13:58PM -0700, Michel Thierry wrote: > On 16/05/17 00:54, Chris Wilson wrote: > >On Mon, May 15, 2017 at 03:25:27PM -0700, Michel Thierry wrote: > >>On 5/15/2017 2:47 PM, Chris Wilson wrote: > >>>On Mon, May 15, 2017 at 10:31:58PM +0100, Chris Wilson wrote: > On Mon,