Re: [Intel-gfx] [PATCH 06/12] drm/i915: Name the inner most per-engine intel_context struct

2016-05-23 Thread Chris Wilson
On Mon, May 23, 2016 at 11:55:16AM +0100, Tvrtko Ursulin wrote: > > On 23/05/16 11:17, Chris Wilson wrote: > >On Mon, May 23, 2016 at 10:26:39AM +0100, Tvrtko Ursulin wrote: > >>>@@ -385,20 +384,18 @@ static void guc_init_ctx_desc(struct intel_guc *guc, > >>>* for now who owns a GuC cl

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Name the inner most per-engine intel_context struct

2016-05-23 Thread Tvrtko Ursulin
On 23/05/16 11:17, Chris Wilson wrote: On Mon, May 23, 2016 at 10:26:39AM +0100, Tvrtko Ursulin wrote: @@ -385,20 +384,18 @@ static void guc_init_ctx_desc(struct intel_guc *guc, * for now who owns a GuC client. But for future owner of GuC * client, need to make

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Name the inner most per-engine intel_context struct

2016-05-23 Thread Chris Wilson
On Mon, May 23, 2016 at 10:26:39AM +0100, Tvrtko Ursulin wrote: > >@@ -385,20 +384,18 @@ static void guc_init_ctx_desc(struct intel_guc *guc, > > * for now who owns a GuC client. But for future owner of GuC > > * client, need to make sure lrc is pinned prior to enter here.

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Name the inner most per-engine intel_context struct

2016-05-23 Thread Tvrtko Ursulin
On 22/05/16 14:02, Chris Wilson wrote: We want to give a name to the currently anonymous per-engine struct inside the context, so that we can assign it to a local variable and save clumsy typing. The name we have chosen is intel_context as it reflects the HW facing portion of the context state (

[Intel-gfx] [PATCH 06/12] drm/i915: Name the inner most per-engine intel_context struct

2016-05-22 Thread Chris Wilson
We want to give a name to the currently anonymous per-engine struct inside the context, so that we can assign it to a local variable and save clumsy typing. The name we have chosen is intel_context as it reflects the HW facing portion of the context state (the logical context state, the registers,