Re: [Intel-gfx] [PATCH 06/14] drm: extract drm_atomic_uapi.c

2018-09-05 Thread Daniel Vetter
On Tue, Sep 04, 2018 at 01:41:33PM -0700, Rodrigo Vivi wrote: > Maybe start a new file with SPDX identifier? > > I like the idea of this split... I just checked, none of the other drm files have them. I'm not sure I want to start this specific bikeshed, so I think I'll leave it as-is. >

Re: [Intel-gfx] [PATCH 06/14] drm: extract drm_atomic_uapi.c

2018-09-04 Thread Rodrigo Vivi
On Mon, Sep 03, 2018 at 06:54:31PM +0200, Daniel Vetter wrote: > This leaves all the commit/check and state handling in drm_atomic.c, > while pulling all the uapi glue and the huge ioctl itself into a > seprate file. > > This seems to almost perfectly split the rather big drm_atomic.c file > into

[Intel-gfx] [PATCH 06/14] drm: extract drm_atomic_uapi.c

2018-09-03 Thread Daniel Vetter
This leaves all the commit/check and state handling in drm_atomic.c, while pulling all the uapi glue and the huge ioctl itself into a seprate file. This seems to almost perfectly split the rather big drm_atomic.c file into 2 equal sizes. Also adjust the kerneldoc and type a very terse overview