Re: [Intel-gfx] [PATCH 06/18] drm/i915/guc: Drop guc->interrupts.enabled

2021-05-27 Thread Matthew Brost
On Thu, May 27, 2021 at 10:17:20AM -0700, John Harrison wrote: > On 5/25/2021 23:42, Matthew Brost wrote: > > Drop the variable guc->interrupts.enabled as this variable is just > > leading to bugs creeping into the code. > > > > e.g. A full GPU reset disables the GuC interrupts but forgot to clear

Re: [Intel-gfx] [PATCH 06/18] drm/i915/guc: Drop guc->interrupts.enabled

2021-05-27 Thread John Harrison
On 5/25/2021 23:42, Matthew Brost wrote: Drop the variable guc->interrupts.enabled as this variable is just leading to bugs creeping into the code. e.g. A full GPU reset disables the GuC interrupts but forgot to clear guc->interrupts.enabled, guc->interrupts.enabled being true suppresses interru

[Intel-gfx] [PATCH 06/18] drm/i915/guc: Drop guc->interrupts.enabled

2021-05-25 Thread Matthew Brost
Drop the variable guc->interrupts.enabled as this variable is just leading to bugs creeping into the code. e.g. A full GPU reset disables the GuC interrupts but forgot to clear guc->interrupts.enabled, guc->interrupts.enabled being true suppresses interrupts from getting re-enabled and now we are