[Intel-gfx] [PATCH 06/37] drm/i915: add DDI registers

2012-03-21 Thread Eugeni Dodonov
There is one set of such registers for each pipe (A/B/C/EDP). Signed-off-by: Eugeni Dodonov --- drivers/gpu/drm/i915/i915_reg.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index ddc9c87..09b2

Re: [Intel-gfx] [PATCH 06/37] drm/i915: add DDI registers

2012-03-26 Thread Rodrigo Vivi
*indentation and it is missing #define PIPE_DDI_MODE_SELECT_DP_MST (3<<24) Otherwise: Reviewed-by: Rodrigo Vivi On Wed, Mar 21, 2012 at 10:09 PM, Eugeni Dodonov wrote: > There is one set of such registers for each pipe (A/B/C/EDP). > > Signed-off-by: Eugeni Dodonov > --- >  drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH 06/37] drm/i915: add DDI registers

2012-03-26 Thread Eugeni Dodonov
On Mon, Mar 26, 2012 at 14:35, Rodrigo Vivi wrote: > *indentation > and it is missing > #define PIPE_DDI_MODE_SELECT_DP_MST (3<<24) > > Otherwise: > Reviewed-by: Rodrigo Vivi > We are not using this bit, this is why I am not exposing it... -- Eugeni Dodonov

Re: [Intel-gfx] [PATCH 06/37] drm/i915: add DDI registers

2012-03-26 Thread Rodrigo Vivi
ah ok, no problem than... I just imagine that this would be useful because in other places you mentioned the DP MST mode... On Mon, Mar 26, 2012 at 2:58 PM, Eugeni Dodonov wrote: > On Mon, Mar 26, 2012 at 14:35, Rodrigo Vivi wrote: >> >> *indentation >> and it is missing >> #define  PIPE_DDI_MO