Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-12 Thread Ankitprasad Sharma
On Mon, 2016-01-11 at 21:29 +, Chris Wilson wrote: > On Mon, Jan 11, 2016 at 05:15:54PM +, Tvrtko Ursulin wrote: > > > Is that not what was written? I take it my telepathy isn't working > > > again. > > > > Sorry not a new loop, new case in a old loop. This is the hunk I think > > is not h

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-11 Thread Chris Wilson
On Mon, Jan 11, 2016 at 05:15:54PM +, Tvrtko Ursulin wrote: > > Is that not what was written? I take it my telepathy isn't working > > again. > > Sorry not a new loop, new case in a old loop. This is the hunk I think > is not helping readability: > > @@ -869,11 +967,29 @@ i915_gem_gtt_pwrite_

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-11 Thread Tvrtko Ursulin
On 11/01/16 17:03, Chris Wilson wrote: > On Mon, Jan 11, 2016 at 03:11:07PM +, Tvrtko Ursulin wrote: >> >> On 11/01/16 14:45, Chris Wilson wrote: >>> On Mon, Jan 11, 2016 at 02:21:33PM +, Tvrtko Ursulin wrote: On 22/12/15 17:40, Chris Wilson wrote: > On Tue, Dec 22, 2015 at

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-11 Thread Chris Wilson
On Mon, Jan 11, 2016 at 03:11:07PM +, Tvrtko Ursulin wrote: > > On 11/01/16 14:45, Chris Wilson wrote: > >On Mon, Jan 11, 2016 at 02:21:33PM +, Tvrtko Ursulin wrote: > >> > >>On 22/12/15 17:40, Chris Wilson wrote: > >>>On Tue, Dec 22, 2015 at 11:58:33AM +, Tvrtko Ursulin wrote: > M

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-11 Thread Tvrtko Ursulin
On 11/01/16 14:45, Chris Wilson wrote: On Mon, Jan 11, 2016 at 02:21:33PM +, Tvrtko Ursulin wrote: On 22/12/15 17:40, Chris Wilson wrote: On Tue, Dec 22, 2015 at 11:58:33AM +, Tvrtko Ursulin wrote: Maybe: if (!obj->base.filp || cpu_write_needs_clflush(obj)) r

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-11 Thread Chris Wilson
On Mon, Jan 11, 2016 at 02:21:33PM +, Tvrtko Ursulin wrote: > > On 22/12/15 17:40, Chris Wilson wrote: > >On Tue, Dec 22, 2015 at 11:58:33AM +, Tvrtko Ursulin wrote: > >>Maybe: > >> > >>if (!obj->base.filp || cpu_write_needs_clflush(obj)) > >>ret = i915_gem_gtt_pwri

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-01-11 Thread Tvrtko Ursulin
On 22/12/15 17:40, Chris Wilson wrote: On Tue, Dec 22, 2015 at 11:58:33AM +, Tvrtko Ursulin wrote: Maybe: if (!obj->base.filp || cpu_write_needs_clflush(obj)) ret = i915_gem_gtt_pwrite_fast(...); if (ret == -EFAULT && !obj->base.filp) { ret

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-12-22 Thread Chris Wilson
On Tue, Dec 22, 2015 at 11:58:33AM +, Tvrtko Ursulin wrote: > Maybe: > > if (!obj->base.filp || cpu_write_needs_clflush(obj)) > ret = i915_gem_gtt_pwrite_fast(...); > > if (ret == -EFAULT && !obj->base.filp) { > ret = i915_gem_gtt_pwrite_slow(...) /* Ne

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-12-22 Thread Tvrtko Ursulin
On 22/12/15 06:20, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma This patch adds support for extending the pread/pwrite functionality for objects not backed by shmem. The access will be made through gtt interface. This will cover objects backed by stolen memory as well as oth

[Intel-gfx] [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-12-21 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for extending the pread/pwrite functionality for objects not backed by shmem. The access will be made through gtt interface. This will cover objects backed by stolen memory as well as other non-shmem backed objects. v2: Drop locks around slow_user