Re: [Intel-gfx] [PATCH 07/12] drm/i915/bdw: Set initial rps freq to RP0

2014-03-24 Thread Ben Widawsky
On Sat, Mar 22, 2014 at 09:06:00PM +, Chris Wilson wrote: > On Sat, Mar 22, 2014 at 11:42:17AM -0700, Ben Widawsky wrote: > > On Thu, Mar 20, 2014 at 07:24:38AM +, Chris Wilson wrote: > > > On Wed, Mar 19, 2014 at 06:31:14PM -0700, Ben Widawsky wrote: > > > > Programming it outside of the r

Re: [Intel-gfx] [PATCH 07/12] drm/i915/bdw: Set initial rps freq to RP0

2014-03-22 Thread Chris Wilson
On Sat, Mar 22, 2014 at 11:42:17AM -0700, Ben Widawsky wrote: > On Thu, Mar 20, 2014 at 07:24:38AM +, Chris Wilson wrote: > > On Wed, Mar 19, 2014 at 06:31:14PM -0700, Ben Widawsky wrote: > > > Programming it outside of the rp0-rp1 range is considered a programming > > > error. Since we do not

Re: [Intel-gfx] [PATCH 07/12] drm/i915/bdw: Set initial rps freq to RP0

2014-03-22 Thread Ben Widawsky
On Thu, Mar 20, 2014 at 07:24:38AM +, Chris Wilson wrote: > On Wed, Mar 19, 2014 at 06:31:14PM -0700, Ben Widawsky wrote: > > Programming it outside of the rp0-rp1 range is considered a programming > > error. Since we do not know that the previous value would actually be in > > the range, progr

Re: [Intel-gfx] [PATCH 07/12] drm/i915/bdw: Set initial rps freq to RP0

2014-03-20 Thread Chris Wilson
On Wed, Mar 19, 2014 at 06:31:14PM -0700, Ben Widawsky wrote: > Programming it outside of the rp0-rp1 range is considered a programming > error. Since we do not know that the previous value would actually be in > the range, program something we've read from the hardware, and therefore > know will w

[Intel-gfx] [PATCH 07/12] drm/i915/bdw: Set initial rps freq to RP0

2014-03-19 Thread Ben Widawsky
Programming it outside of the rp0-rp1 range is considered a programming error. Since we do not know that the previous value would actually be in the range, program something we've read from the hardware, and therefore know will work. This is potentially an issue for platforms whose ranges are outs