Re: [Intel-gfx] [PATCH 07/12] drm/irq: kerneldoc polish

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 01:44:04PM +0900, Michel Dänzer wrote: > On 15.05.2014 03:51, Daniel Vetter wrote: > > @@ -964,8 +1005,13 @@ EXPORT_SYMBOL(drm_vblank_off); > > > > /** > > * drm_vblank_on - enable vblank events on a CRTC > > - * @dev: DRM device > > + * @dev: drm device > > * @crtc:

Re: [Intel-gfx] [PATCH 07/12] drm/irq: kerneldoc polish

2014-05-15 Thread Thierry Reding
On Wed, May 14, 2014 at 08:51:09PM +0200, Daniel Vetter wrote: [...] > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c [...] > index dd786d84daab..5ff986bd4de4 100644 > --- a/drivers/gpu/drm/drm_irq.c > +++ b/drivers/gpu/drm/drm_irq.c > @@ -1,6 +1,5 @@ > -/** > - * \file drm_irq.

Re: [Intel-gfx] [PATCH 07/12] drm/irq: kerneldoc polish

2014-05-14 Thread Michel Dänzer
On 15.05.2014 03:51, Daniel Vetter wrote: > @@ -964,8 +1005,13 @@ EXPORT_SYMBOL(drm_vblank_off); > > /** > * drm_vblank_on - enable vblank events on a CRTC > - * @dev: DRM device > + * @dev: drm device > * @crtc: CRTC in question > + * > + * This functions restores the vblank interrupt state

[Intel-gfx] [PATCH 07/12] drm/irq: kerneldoc polish

2014-05-14 Thread Daniel Vetter
- Integrate into the drm DocBook - Disable kerneldoc for functions not exported to drivers. - Properly document the new drm_vblank_on|off and add cautious comments explaining when drm_vblank_pre|post_modesets shouldn't be used. - General polish and OCD. Signed-off-by: Daniel Vetter --- Docum