Re: [Intel-gfx] [PATCH 07/18] drm/i915: fix the __intel_fbc_update() comments

2015-10-22 Thread Zanoni, Paulo R
Em Qua, 2015-10-21 às 18:38 +0100, ch...@chris-wilson.co.uk escreveu: > On Wed, Oct 21, 2015 at 05:32:16PM +, Zanoni, Paulo R wrote: > > Em Qua, 2015-10-21 às 13:37 +0100, Chris Wilson escreveu: > > > On Tue, Oct 20, 2015 at 11:49:53AM -0200, Paulo Zanoni wrote: > > > > Don't try to list in com

Re: [Intel-gfx] [PATCH 07/18] drm/i915: fix the __intel_fbc_update() comments

2015-10-21 Thread ch...@chris-wilson.co.uk
On Wed, Oct 21, 2015 at 05:32:16PM +, Zanoni, Paulo R wrote: > Em Qua, 2015-10-21 às 13:37 +0100, Chris Wilson escreveu: > > On Tue, Oct 20, 2015 at 11:49:53AM -0200, Paulo Zanoni wrote: > > > Don't try to list in comments the cases where we should enable or > > > disable FBC: it varies a lot w

Re: [Intel-gfx] [PATCH 07/18] drm/i915: fix the __intel_fbc_update() comments

2015-10-21 Thread Zanoni, Paulo R
Em Qua, 2015-10-21 às 13:37 +0100, Chris Wilson escreveu: > On Tue, Oct 20, 2015 at 11:49:53AM -0200, Paulo Zanoni wrote: > > Don't try to list in comments the cases where we should enable or > > disable FBC: it varies a lot with the hardware generations and the > > code should be the documentation

Re: [Intel-gfx] [PATCH 07/18] drm/i915: fix the __intel_fbc_update() comments

2015-10-21 Thread Chris Wilson
On Tue, Oct 20, 2015 at 11:49:53AM -0200, Paulo Zanoni wrote: > Don't try to list in comments the cases where we should enable or > disable FBC: it varies a lot with the hardware generations and the > code should be the documentation. Also notice that there's already a > huge gap between the commen

[Intel-gfx] [PATCH 07/18] drm/i915: fix the __intel_fbc_update() comments

2015-10-20 Thread Paulo Zanoni
Don't try to list in comments the cases where we should enable or disable FBC: it varies a lot with the hardware generations and the code should be the documentation. Also notice that there's already a huge gap between the comments and what's in the code. Signed-off-by: Paulo Zanoni --- drivers/