Re: [Intel-gfx] [PATCH 07/31] drm/i915: IPS Sysfs interface.

2015-11-18 Thread Vivi, Rodrigo
On Wed, 2015-11-18 at 11:04 +0100, Daniel Vetter wrote: > On Thu, Nov 05, 2015 at 09:04:02PM +, Chris Wilson wrote: > > On Thu, Nov 05, 2015 at 10:49:59AM -0800, Rodrigo Vivi wrote: > > > With the lock in place we can expose ips enabled/disable on sysfs > > > for developing, debugging and infor

Re: [Intel-gfx] [PATCH 07/31] drm/i915: IPS Sysfs interface.

2015-11-18 Thread Daniel Vetter
On Thu, Nov 05, 2015 at 09:04:02PM +, Chris Wilson wrote: > On Thu, Nov 05, 2015 at 10:49:59AM -0800, Rodrigo Vivi wrote: > > With the lock in place we can expose ips enabled/disable on sysfs > > for developing, debugging and information purposes. > > No. sysfs is not for developement, debuggi

Re: [Intel-gfx] [PATCH 07/31] drm/i915: IPS Sysfs interface.

2015-11-09 Thread Daniel Stone
Hi Rodrigo, On 5 November 2015 at 18:49, Rodrigo Vivi wrote: > diff --git a/drivers/gpu/drm/i915/intel_ips.c > b/drivers/gpu/drm/i915/intel_ips.c > index b867aba..6bc5c55 100644 > --- a/drivers/gpu/drm/i915/intel_ips.c > +++ b/drivers/gpu/drm/i915/intel_ips.c > @@ -105,18 +105,21 @@ bool intel_i

Re: [Intel-gfx] [PATCH 07/31] drm/i915: IPS Sysfs interface.

2015-11-05 Thread Chris Wilson
On Thu, Nov 05, 2015 at 10:49:59AM -0800, Rodrigo Vivi wrote: > With the lock in place we can expose ips enabled/disable on sysfs > for developing, debugging and information purposes. No. sysfs is not for developement, debugging or information. It is a userspace ABI. -Chris -- Chris Wilson, Inte

[Intel-gfx] [PATCH 07/31] drm/i915: IPS Sysfs interface.

2015-11-05 Thread Rodrigo Vivi
With the lock in place we can expose ips enabled/disable on sysfs for developing, debugging and information purposes. The main goal is to have an informative tab at powertop that expose the current status of power features in our driver. So let's start with this IPS one. Please remind that powerto