Re: [Intel-gfx] [PATCH 08/12] drm/irq: Add kms-native crtc interface functions

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 12:42 PM, Thierry Reding wrote: > On Thu, May 15, 2014 at 12:10:16PM +0200, Daniel Vetter wrote: >> On Thu, May 15, 2014 at 9:34 AM, Thierry Reding >> wrote: >> > This seems slightly backwards. Since drm_vblank_get() is what's being >> > deprecated here, wouldn't it make m

Re: [Intel-gfx] [PATCH 08/12] drm/irq: Add kms-native crtc interface functions

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 12:10:16PM +0200, Daniel Vetter wrote: > On Thu, May 15, 2014 at 9:34 AM, Thierry Reding > wrote: > > This seems slightly backwards. Since drm_vblank_get() is what's being > > deprecated here, wouldn't it make more sense to write > > drm_crtc_vblank_get() in terms of struct

Re: [Intel-gfx] [PATCH 08/12] drm/irq: Add kms-native crtc interface functions

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 9:34 AM, Thierry Reding wrote: > This seems slightly backwards. Since drm_vblank_get() is what's being > deprecated here, wouldn't it make more sense to write > drm_crtc_vblank_get() in terms of struct drm_crtc and make > drm_vblank_get() call that instead? I can't seem to

Re: [Intel-gfx] [PATCH 08/12] drm/irq: Add kms-native crtc interface functions

2014-05-15 Thread Thierry Reding
On Wed, May 14, 2014 at 08:51:10PM +0200, Daniel Vetter wrote: > We need to start somewhere ... With this the only places left in i915 > where we use pipe integers is in the interrupt handling code. And > there it actually makes some amount of sense. Very much welcome addition. Some minor comments

[Intel-gfx] [PATCH 08/12] drm/irq: Add kms-native crtc interface functions

2014-05-14 Thread Daniel Vetter
We need to start somewhere ... With this the only places left in i915 where we use pipe integers is in the interrupt handling code. And there it actually makes some amount of sense. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_irq.c| 81 d