Re: [Intel-gfx] [PATCH 08/13] drm/i915: Move active watermarks into CRTC state (v2)

2015-08-26 Thread Ville Syrjälä
On Thu, Aug 20, 2015 at 06:11:59PM -0700, Matt Roper wrote: > Since we allocate a few CRTC states on the stack, also switch the 'wm' > struct here to be a union so that we're not wasting stack space with > other platforms' watermark values. > I don't like this patch. The locking rules (once we ha

[Intel-gfx] [PATCH 08/13] drm/i915: Move active watermarks into CRTC state (v2)

2015-08-20 Thread Matt Roper
Since we allocate a few CRTC states on the stack, also switch the 'wm' struct here to be a union so that we're not wasting stack space with other platforms' watermark values. v2: Don't move cxsr_allowed to state (Maarten) Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_drv.h | 45 +