Re: [Intel-gfx] [PATCH 08/13] drm/i915: Pin after setting to the display plane

2011-04-14 Thread Chris Wilson
On Thu, 14 Apr 2011 19:34:17 +0200, Daniel Vetter wrote: > After the movement all three code-paths suffer from > if (ret) > goto foo_unpin; > before anything is actually pinned. With that fixed, it's My only defense was that was about the third or fifth variation that I tried

Re: [Intel-gfx] [PATCH 08/13] drm/i915: Pin after setting to the display plane

2011-04-14 Thread Daniel Vetter
On Thu, Apr 14, 2011 at 10:03:42AM +0100, Chris Wilson wrote: > A few operations we do in order to move the object into the display > plane it is important for future safety to forbid whilst pinned. As a > result, we want to pin afterwards. At the moment, setting to the display > plane of an unboun

[Intel-gfx] [PATCH 08/13] drm/i915: Pin after setting to the display plane

2011-04-14 Thread Chris Wilson
A few operations we do in order to move the object into the display plane it is important for future safety to forbid whilst pinned. As a result, we want to pin afterwards. At the moment, setting to the display plane of an unbound object is simply to bind it, so set_to_display_plane() becomes a no-