Re: [Intel-gfx] [PATCH 08/20] drm/i915: Promote ptrdiff() to i915_utils.h

2021-06-04 Thread Daniel Vetter
On Thu, Jun 03, 2021 at 07:02:57PM -0700, Matthew Brost wrote: > On Thu, Jun 03, 2021 at 11:35:28PM +0200, Daniel Vetter wrote: > > On Wed, Jun 02, 2021 at 10:16:18PM -0700, Matthew Brost wrote: > > > From: Michal Wajdeczko > > > > > > Generic helpers should be placed in i915_utils.h. > > > > Ra

Re: [Intel-gfx] [PATCH 08/20] drm/i915: Promote ptrdiff() to i915_utils.h

2021-06-03 Thread Matthew Brost
On Thu, Jun 03, 2021 at 11:35:28PM +0200, Daniel Vetter wrote: > On Wed, Jun 02, 2021 at 10:16:18PM -0700, Matthew Brost wrote: > > From: Michal Wajdeczko > > > > Generic helpers should be placed in i915_utils.h. > > Random rant, but we're _way_ too happy to just stuff random things into > i915_

Re: [Intel-gfx] [PATCH 08/20] drm/i915: Promote ptrdiff() to i915_utils.h

2021-06-03 Thread Daniel Vetter
On Wed, Jun 02, 2021 at 10:16:18PM -0700, Matthew Brost wrote: > From: Michal Wajdeczko > > Generic helpers should be placed in i915_utils.h. Random rant, but we're _way_ too happy to just stuff random things into i915_utils.h without trying to properly upstream it. For thinks like this the gen

[Intel-gfx] [PATCH 08/20] drm/i915: Promote ptrdiff() to i915_utils.h

2021-06-02 Thread Matthew Brost
From: Michal Wajdeczko Generic helpers should be placed in i915_utils.h. Signed-off-by: Michal Wajdeczko Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/i915_utils.h | 5 + drivers/gpu/drm/i915/i915_vma.h | 5 - 2 files changed, 5 insertions(+), 5 d