Re: [Intel-gfx] [PATCH 08/24] drm/i915: Shuffle wait_for_vblank out of primary_enable/disable funcs

2014-04-29 Thread Daniel Vetter
On Tue, Apr 08, 2014 at 09:55:45PM +0300, Ville Syrjälä wrote: On Mon, Apr 07, 2014 at 05:27:41PM -0300, Paulo Zanoni wrote: 2014-03-07 13:32 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Rather than have a wait_for_vblank() in the primary

Re: [Intel-gfx] [PATCH 08/24] drm/i915: Shuffle wait_for_vblank out of primary_enable/disable funcs

2014-04-08 Thread Ville Syrjälä
On Mon, Apr 07, 2014 at 05:27:41PM -0300, Paulo Zanoni wrote: 2014-03-07 13:32 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Rather than have a wait_for_vblank() in the primary plane enable/disable funcs, move the wait_for_vblank() to happen

Re: [Intel-gfx] [PATCH 08/24] drm/i915: Shuffle wait_for_vblank out of primary_enable/disable funcs

2014-04-07 Thread Paulo Zanoni
2014-03-07 13:32 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Rather than have a wait_for_vblank() in the primary plane enable/disable funcs, move the wait_for_vblank() to happen after enabling/disabling all planes. Why exactly? What is

[Intel-gfx] [PATCH 08/24] drm/i915: Shuffle wait_for_vblank out of primary_enable/disable funcs

2014-03-07 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Rather than have a wait_for_vblank() in the primary plane enable/disable funcs, move the wait_for_vblank() to happen after enabling/disabling all planes. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com ---