Re: [Intel-gfx] [PATCH 09/12] drm/i915: rip our vblank reset hacks for runtime PM

2014-05-21 Thread Thierry Reding
On Tue, May 20, 2014 at 03:03:41PM +0300, Ville Syrjälä wrote: On Wed, May 14, 2014 at 08:51:11PM +0200, Daniel Vetter wrote: Now that we unconditionally dtrt when disabling/enabling crtcs we don't need any hacks any longer to keep the vblank logic sane when all the registers go poof. So

Re: [Intel-gfx] [PATCH 09/12] drm/i915: rip our vblank reset hacks for runtime PM

2014-05-20 Thread Ville Syrjälä
On Wed, May 14, 2014 at 08:51:11PM +0200, Daniel Vetter wrote: Now that we unconditionally dtrt when disabling/enabling crtcs we don't need any hacks any longer to keep the vblank logic sane when all the registers go poof. So let's rip it all out. Hmm. drm_update_vblank_count() will now see

Re: [Intel-gfx] [PATCH 09/12] drm/i915: rip our vblank reset hacks for runtime PM

2014-05-20 Thread Daniel Vetter
On Tue, May 20, 2014 at 03:03:41PM +0300, Ville Syrjälä wrote: On Wed, May 14, 2014 at 08:51:11PM +0200, Daniel Vetter wrote: Now that we unconditionally dtrt when disabling/enabling crtcs we don't need any hacks any longer to keep the vblank logic sane when all the registers go poof. So

Re: [Intel-gfx] [PATCH 09/12] drm/i915: rip our vblank reset hacks for runtime PM

2014-05-20 Thread Ville Syrjälä
On Tue, May 20, 2014 at 03:38:14PM +0200, Daniel Vetter wrote: On Tue, May 20, 2014 at 03:03:41PM +0300, Ville Syrjälä wrote: On Wed, May 14, 2014 at 08:51:11PM +0200, Daniel Vetter wrote: Now that we unconditionally dtrt when disabling/enabling crtcs we don't need any hacks any longer to

Re: [Intel-gfx] [PATCH 09/12] drm/i915: rip our vblank reset hacks for runtime PM

2014-05-20 Thread Daniel Vetter
On Tue, May 20, 2014 at 05:03:33PM +0300, Ville Syrjälä wrote: On Tue, May 20, 2014 at 03:38:14PM +0200, Daniel Vetter wrote: On Tue, May 20, 2014 at 03:03:41PM +0300, Ville Syrjälä wrote: On Wed, May 14, 2014 at 08:51:11PM +0200, Daniel Vetter wrote: Now that we unconditionally dtrt

Re: [Intel-gfx] [PATCH 09/12] drm/i915: rip our vblank reset hacks for runtime PM

2014-05-20 Thread Daniel Vetter
On Tue, May 20, 2014 at 4:20 PM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, May 20, 2014 at 05:03:33PM +0300, Ville Syrjälä wrote: On Tue, May 20, 2014 at 03:38:14PM +0200, Daniel Vetter wrote: On Tue, May 20, 2014 at 03:03:41PM +0300, Ville Syrjälä wrote: On Wed, May 14, 2014 at

[Intel-gfx] [PATCH 09/12] drm/i915: rip our vblank reset hacks for runtime PM

2014-05-14 Thread Daniel Vetter
Now that we unconditionally dtrt when disabling/enabling crtcs we don't need any hacks any longer to keep the vblank logic sane when all the registers go poof. So let's rip it all out. This essentially undoes commit 9dbd8febb4dbc9199fcf340b882eb930e36b65b6 Author: Paulo Zanoni