Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Goel, Akash
On 7/20/2016 5:20 PM, Tvrtko Ursulin wrote: On 20/07/16 12:29, Goel, Akash wrote: On 7/20/2016 4:10 PM, Tvrtko Ursulin wrote: On 20/07/16 11:12, Goel, Akash wrote: On 7/20/2016 3:17 PM, Tvrtko Ursulin wrote: +DEFINE_SIMPLE_ATTRIBUTE(i915_guc_log_control_fops, +NULL, i915_guc_

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Tvrtko Ursulin
On 20/07/16 12:29, Goel, Akash wrote: On 7/20/2016 4:10 PM, Tvrtko Ursulin wrote: On 20/07/16 11:12, Goel, Akash wrote: On 7/20/2016 3:17 PM, Tvrtko Ursulin wrote: +ret = -EINVAL; +goto end; +} + +intel_runtime_pm_get(dev_priv); +ret = i915_guc_log_control(dev, val

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Goel, Akash
On 7/20/2016 4:10 PM, Tvrtko Ursulin wrote: On 20/07/16 11:12, Goel, Akash wrote: On 7/20/2016 3:17 PM, Tvrtko Ursulin wrote: +ret = -EINVAL; +goto end; +} + +intel_runtime_pm_get(dev_priv); +ret = i915_guc_log_control(dev, val); +intel_runtime_pm_put(dev_priv

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Tvrtko Ursulin
On 20/07/16 11:12, Goel, Akash wrote: On 7/20/2016 3:17 PM, Tvrtko Ursulin wrote: +ret = -EINVAL; +goto end; +} + +intel_runtime_pm_get(dev_priv); +ret = i915_guc_log_control(dev, val); +intel_runtime_pm_put(dev_priv); + +end: +mutex_unlock(&dev->struct_mutex

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Goel, Akash
On 7/20/2016 3:17 PM, Tvrtko Ursulin wrote: On 20/07/16 10:32, Goel, Akash wrote: On 7/20/2016 2:38 PM, Tvrtko Ursulin wrote: On 20/07/16 05:42, Goel, Akash wrote: On 7/19/2016 4:54 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble This

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Tvrtko Ursulin
On 20/07/16 10:32, Goel, Akash wrote: On 7/20/2016 2:38 PM, Tvrtko Ursulin wrote: On 20/07/16 05:42, Goel, Akash wrote: On 7/19/2016 4:54 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_outp

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Goel, Akash
On 7/20/2016 2:38 PM, Tvrtko Ursulin wrote: On 20/07/16 05:42, Goel, Akash wrote: On 7/19/2016 4:54 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_output_control for on the fly enabling/disab

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-20 Thread Tvrtko Ursulin
On 20/07/16 05:42, Goel, Akash wrote: On 7/19/2016 4:54 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_output_control for on the fly enabling/disabling of logging in GuC firmware and controlling

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-19 Thread Goel, Akash
On 7/19/2016 4:54 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_output_control for on the fly enabling/disabling of logging in GuC firmware and controlling the verbosity level of logs. The valu

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-19 Thread Tvrtko Ursulin
On 10/07/16 14:41, akash.g...@intel.com wrote: From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_output_control for on the fly enabling/disabling of logging in GuC firmware and controlling the verbosity level of logs. The value written to the file, should have bit 0 set to

Re: [Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-10 Thread kbuild test robot
Hi, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20160708] [cannot apply to v4.7-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/akash-goel-intel-com/Su

[Intel-gfx] [PATCH 09/17] drm/i915: Debugfs support for GuC logging control

2016-07-10 Thread akash . goel
From: Sagar Arun Kamble This patch provides debugfs interface i915_guc_output_control for on the fly enabling/disabling of logging in GuC firmware and controlling the verbosity level of logs. The value written to the file, should have bit 0 set to enable logging and bits 4-7 should contain the ve