Re: [Intel-gfx] [PATCH 09/26] drm/i915: Split out gtt specific header file

2014-03-22 Thread Ben Widawsky
On Tue, Mar 18, 2014 at 10:15:56AM +0100, Daniel Vetter wrote: On Mon, Mar 17, 2014 at 10:48:41PM -0700, Ben Widawsky wrote: TODO: Do header files need a copyright? Yup ;-) I like this though, especially since finer-grained files will make kerneldoc inclusion (well, grouped into sensible

Re: [Intel-gfx] [PATCH 09/26] drm/i915: Split out gtt specific header file

2014-03-22 Thread Daniel Vetter
On Sat, Mar 22, 2014 at 8:44 PM, Ben Widawsky b...@bwidawsk.net wrote: On Tue, Mar 18, 2014 at 10:15:56AM +0100, Daniel Vetter wrote: On Mon, Mar 17, 2014 at 10:48:41PM -0700, Ben Widawsky wrote: TODO: Do header files need a copyright? Yup ;-) I like this though, especially since

Re: [Intel-gfx] [PATCH 09/26] drm/i915: Split out gtt specific header file

2014-03-18 Thread Chris Wilson
On Mon, Mar 17, 2014 at 10:48:41PM -0700, Ben Widawsky wrote: TODO: Do header files need a copyright? Short answer: yes. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 09/26] drm/i915: Split out gtt specific header file

2014-03-18 Thread Daniel Vetter
On Mon, Mar 17, 2014 at 10:48:41PM -0700, Ben Widawsky wrote: TODO: Do header files need a copyright? Yup ;-) I like this though, especially since finer-grained files will make kerneldoc inclusion (well, grouped into sensible chapters at least) much simpler. -Daniel Signed-off-by: Ben

[Intel-gfx] [PATCH 09/26] drm/i915: Split out gtt specific header file

2014-03-17 Thread Ben Widawsky
TODO: Do header files need a copyright? Signed-off-by: Ben Widawsky b...@bwidawsk.net --- drivers/gpu/drm/i915/i915_drv.h | 162 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 57 - drivers/gpu/drm/i915/i915_gem_gtt.h | 225 3