Re: [Intel-gfx] [PATCH 1/1] drm/i915: Do not enable PSR2/selective fetch if there are no planes

2022-06-15 Thread Lisovskiy, Stanislav
On Tue, Jun 14, 2022 at 03:55:04PM +0300, Hogander, Jouni wrote: > On Tue, 2022-06-14 at 15:22 +0300, Stanislav Lisovskiy wrote: > > We seem to enable PSR2 and selective fetch even if there are no > > active > > planes. That seems to causes FIFO underruns at least for ADLP. > > Those are gone if we

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Do not enable PSR2/selective fetch if there are no planes

2022-06-15 Thread Lisovskiy, Stanislav
On Tue, Jun 14, 2022 at 03:55:04PM +0300, Hogander, Jouni wrote: > On Tue, 2022-06-14 at 15:22 +0300, Stanislav Lisovskiy wrote: > > We seem to enable PSR2 and selective fetch even if there are no > > active > > planes. That seems to causes FIFO underruns at least for ADLP. > > Those are gone if we

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Do not enable PSR2/selective fetch if there are no planes

2022-06-14 Thread Hogander, Jouni
On Tue, 2022-06-14 at 15:22 +0300, Stanislav Lisovskiy wrote: > We seem to enable PSR2 and selective fetch even if there are no > active > planes. That seems to causes FIFO underruns at least for ADLP. > Those are gone if we don't do that. Just adding simple check > in intel_psr2_sel_fetch_config_v

[Intel-gfx] [PATCH 1/1] drm/i915: Do not enable PSR2/selective fetch if there are no planes

2022-06-14 Thread Stanislav Lisovskiy
We seem to enable PSR2 and selective fetch even if there are no active planes. That seems to causes FIFO underruns at least for ADLP. Those are gone if we don't do that. Just adding simple check in intel_psr2_sel_fetch_config_valid seems to do the trick. Signed-off-by: Stanislav Lisovskiy --- dr