Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

2016-10-25 Thread Daniel Vetter
On Mon, Oct 24, 2016 at 03:43:02PM +0530, Kamble, Sagar A wrote: > Hi Daniel, Chris, > > > Sorry for not clarifying the purpose and if any misunderstanding. > This was to allow running at fixed frequency. > > Kindly clarify if it is intentional to have _store routine without S_IWUSR. > > On 10/

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

2016-10-24 Thread Kamble, Sagar A
Hi Daniel, Chris, Sorry for not clarifying the purpose and if any misunderstanding. This was to allow running at fixed frequency. Kindly clarify if it is intentional to have _store routine without S_IWUSR. On 10/24/2016 2:42 PM, Chris Wilson wrote: On Mon, Oct 24, 2016 at 11:05:13AM +0200, Da

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

2016-10-24 Thread Chris Wilson
On Mon, Oct 24, 2016 at 11:05:13AM +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote: > > And uabi change with 0 commit message. This needs to be _much_ better ;-) A case where the author cut'n'paste the wrong thing because he can't read S_INCOMPREHEN

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

2016-10-24 Thread Daniel Vetter
On Mon, Oct 24, 2016 at 11:05:13AM +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote: > > And uabi change with 0 commit message. This needs to be _much_ better ;-) Also the patch subject isn't really useful: It's a literal translation from the patch t

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

2016-10-24 Thread Daniel Vetter
On Mon, Oct 24, 2016 at 10:00:49AM +0530, Sagar Arun Kamble wrote: And uabi change with 0 commit message. This needs to be _much_ better ;-) -Daniel > Cc: Chris Wilson > Signed-off-by: Sagar Arun Kamble > --- > drivers/gpu/drm/i915/i915_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

[Intel-gfx] [PATCH 1/1] drm/i915: Give write permission to gt_boost_freq_mhz

2016-10-23 Thread Sagar Arun Kamble
Cc: Chris Wilson Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/i915_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c index 47590ab..3df8d3d 100644 --- a/drivers/gpu/drm/i915/i915_sysfs.c