Re: [Intel-gfx] [PATCH 1/2] drm/dsc: fix drm_edp_dsc_sink_output_bpp() DPCD high byte usage

2023-05-02 Thread Jani Nikula
On Thu, 20 Apr 2023, "Nautiyal, Ankit K" wrote: > LGTM. > > Reviewed-by: Ankit Nautiyal Thanks for the reviews, pushed these a week+ ago. BR, Jani. > > On 4/6/2023 7:16 PM, Jani Nikula wrote: >> The operator precedence between << and & is wrong, leading to the high >> byte being completely

Re: [Intel-gfx] [PATCH 1/2] drm/dsc: fix drm_edp_dsc_sink_output_bpp() DPCD high byte usage

2023-04-20 Thread Nautiyal, Ankit K
LGTM. Reviewed-by: Ankit Nautiyal On 4/6/2023 7:16 PM, Jani Nikula wrote: The operator precedence between << and & is wrong, leading to the high byte being completely ignored. For example, with the 6.4 format, 32 becomes 0 and 24 becomes 8. Fix it, and remove the slightly confusing and

[Intel-gfx] [PATCH 1/2] drm/dsc: fix drm_edp_dsc_sink_output_bpp() DPCD high byte usage

2023-04-06 Thread Jani Nikula
The operator precedence between << and & is wrong, leading to the high byte being completely ignored. For example, with the 6.4 format, 32 becomes 0 and 24 becomes 8. Fix it, and remove the slightly confusing and unnecessary DP_DSC_MAX_BITS_PER_PIXEL_HI_SHIFT macro while at it. Fixes: