[Intel-gfx] [PATCH 1/2] drm/i915/dsc: fix DSC register selection for ICL DSI transcoders

2019-12-11 Thread Jani Nikula
ICL eDP and DSI transcoders have a DSC engine separate from the pipe. Abstract the register selection and fix it for ICL. Add a warning for pipe A DSC on ICL; it does not exist. Cc: Manasi Navare Cc: Vandita Kulkarni Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_vdsc.c | 5

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: fix DSC register selection for ICL DSI transcoders

2019-12-11 Thread Manasi Navare
On Wed, Dec 11, 2019 at 06:23:46PM +0200, Jani Nikula wrote: > ICL eDP and DSI transcoders have a DSC engine separate from the > pipe. Abstract the register selection and fix it for ICL. > > Add a warning for pipe A DSC on ICL; it does not exist. > > Cc: Manasi Navare > Cc: Vandita Kulkarni > S

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: fix DSC register selection for ICL DSI transcoders

2019-12-11 Thread Jani Nikula
On Wed, 11 Dec 2019, Manasi Navare wrote: > On Wed, Dec 11, 2019 at 06:23:46PM +0200, Jani Nikula wrote: >> ICL eDP and DSI transcoders have a DSC engine separate from the >> pipe. Abstract the register selection and fix it for ICL. >> >> Add a warning for pipe A DSC on ICL; it does not exist. >>

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: fix DSC register selection for ICL DSI transcoders

2019-12-12 Thread Manasi Navare
On Thu, Dec 12, 2019 at 09:18:48AM +0200, Jani Nikula wrote: > On Wed, 11 Dec 2019, Manasi Navare wrote: > > On Wed, Dec 11, 2019 at 06:23:46PM +0200, Jani Nikula wrote: > >> ICL eDP and DSI transcoders have a DSC engine separate from the > >> pipe. Abstract the register selection and fix it for I

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsc: fix DSC register selection for ICL DSI transcoders

2019-12-12 Thread Manasi Navare
On Thu, Dec 12, 2019 at 02:05:10PM -0800, Manasi Navare wrote: > On Thu, Dec 12, 2019 at 09:18:48AM +0200, Jani Nikula wrote: > > On Wed, 11 Dec 2019, Manasi Navare wrote: > > > On Wed, Dec 11, 2019 at 06:23:46PM +0200, Jani Nikula wrote: > > >> ICL eDP and DSI transcoders have a DSC engine separa