Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-18 Thread Chris Wilson
On Wed, Feb 17, 2016 at 09:48:31AM -0800, Yu Dai wrote: > > > On 02/17/2016 08:04 AM, Daniel Vetter wrote: > >On Tue, Feb 16, 2016 at 08:47:07AM -0800, Yu Dai wrote: > >> > >> > >> On 02/15/2016 07:23 AM, Dave Gordon wrote: > >> >On 12/02/16 13:03, Tvrtko Ursulin wrote: > >> >> > >> >> On 11/02/1

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-17 Thread Yu Dai
On 02/17/2016 08:04 AM, Daniel Vetter wrote: On Tue, Feb 16, 2016 at 08:47:07AM -0800, Yu Dai wrote: > > > On 02/15/2016 07:23 AM, Dave Gordon wrote: > >On 12/02/16 13:03, Tvrtko Ursulin wrote: > >> > >> On 11/02/16 23:09, yu@intel.com wrote: > >>> From: Alex Dai > >>> > >>> GuC client obj

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-17 Thread Daniel Vetter
On Tue, Feb 16, 2016 at 08:47:07AM -0800, Yu Dai wrote: > > > On 02/15/2016 07:23 AM, Dave Gordon wrote: > >On 12/02/16 13:03, Tvrtko Ursulin wrote: > >> > >> On 11/02/16 23:09, yu@intel.com wrote: > >>> From: Alex Dai > >>> > >>> GuC client object is always pinned during its life cycle. We

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-16 Thread Yu Dai
On 02/15/2016 07:23 AM, Dave Gordon wrote: On 12/02/16 13:03, Tvrtko Ursulin wrote: > > On 11/02/16 23:09, yu@intel.com wrote: >> From: Alex Dai >> >> GuC client object is always pinned during its life cycle. We cache >> the kmap of its first page, which includes guc_process_desc and >> do

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-16 Thread Yu Dai
On 02/15/2016 06:39 AM, Dave Gordon wrote: On 12/02/16 13:03, Tvrtko Ursulin wrote: > > On 11/02/16 23:09, yu@intel.com wrote: >> From: Alex Dai >> >> GuC client object is always pinned during its life cycle. We cache >> the kmap of its first page, which includes guc_process_desc and >> do

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-15 Thread Dave Gordon
On 12/02/16 13:03, Tvrtko Ursulin wrote: On 11/02/16 23:09, yu@intel.com wrote: From: Alex Dai GuC client object is always pinned during its life cycle. We cache the kmap of its first page, which includes guc_process_desc and doorbell. By doing so, we can simplify the code where we read f

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-15 Thread Dave Gordon
On 12/02/16 13:03, Tvrtko Ursulin wrote: On 11/02/16 23:09, yu@intel.com wrote: From: Alex Dai GuC client object is always pinned during its life cycle. We cache the kmap of its first page, which includes guc_process_desc and doorbell. By doing so, we can simplify the code where we read f

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-12 Thread Tvrtko Ursulin
On 11/02/16 23:09, yu@intel.com wrote: From: Alex Dai GuC client object is always pinned during its life cycle. We cache the kmap of its first page, which includes guc_process_desc and doorbell. By doing so, we can simplify the code where we read from this page to get where GuC is progress

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Simplify code by keeping kmap of guc_client object

2016-02-11 Thread yu . dai
From: Alex Dai GuC client object is always pinned during its life cycle. We cache the kmap of its first page, which includes guc_process_desc and doorbell. By doing so, we can simplify the code where we read from this page to get where GuC is progressing on work queue; and the code where driver p