Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-12 Thread Jani Nikula
On Tue, 12 Jan 2021, "Vivi, Rodrigo" wrote: > On Mon, 2021-01-11 at 13:25 -0800, Lucas De Marchi wrote: >> last time we talked about this was regarding dg1 AFAIR and the >> consensus was to create a topic branch and that topic branch to be >> merged in both branches. That would avoid having 2 comm

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-12 Thread Vivi, Rodrigo
On Mon, 2021-01-11 at 13:25 -0800, Lucas De Marchi wrote: > On Mon, Jan 11, 2021 at 12:57:43PM -0800, Matt Roper wrote: > > On Mon, Jan 11, 2021 at 10:18:45PM +0200, Jani Nikula wrote: > > > On Mon, 11 Jan 2021, Jani Nikula > > > wrote: > > > > On Fri, 08 Jan 2021, Matt Roper > > > > wrote: > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-12 Thread Matt Roper
On Tue, Jan 12, 2021 at 06:24:50PM +0200, Jani Nikula wrote: > On Mon, 11 Jan 2021, Lucas De Marchi wrote: > > On Mon, Jan 11, 2021 at 12:57:43PM -0800, Matt Roper wrote: > >>On Mon, Jan 11, 2021 at 10:18:45PM +0200, Jani Nikula wrote: > >>So to clarify, it looks like we have a bunch of revid chan

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-12 Thread Jani Nikula
On Mon, 11 Jan 2021, Aditya Swarup wrote: > On 1/11/21 12:57 PM, Matt Roper wrote: >> On Mon, Jan 11, 2021 at 10:18:45PM +0200, Jani Nikula wrote: >>> On Mon, 11 Jan 2021, Jani Nikula wrote: On Fri, 08 Jan 2021, Matt Roper wrote: > On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-12 Thread Jani Nikula
On Mon, 11 Jan 2021, Lucas De Marchi wrote: > On Mon, Jan 11, 2021 at 12:57:43PM -0800, Matt Roper wrote: >>On Mon, Jan 11, 2021 at 10:18:45PM +0200, Jani Nikula wrote: >>So to clarify, it looks like we have a bunch of revid changes to the >>display code that got merged to the gt-next tree but not

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-12 Thread Jani Nikula
On Mon, 11 Jan 2021, Lucas De Marchi wrote: > On Mon, Jan 11, 2021 at 10:13:15PM +0200, Jani Nikula wrote: >>On Fri, 08 Jan 2021, Matt Roper wrote: > in the end both sides will need that (even if it was a mistake to merge > it in drm-intel-gt-next). I got an ack from Rodrigo to actually > cherry

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-12 Thread Jani Nikula
On Mon, 11 Jan 2021, Aditya Swarup wrote: > On 1/11/21 12:13 PM, Jani Nikula wrote: >> On Fri, 08 Jan 2021, Matt Roper wrote: >> FWIW I have a wip series changing the whole thing to abstract steppings >> enums that are shared between platforms, but it's in a bit of limbo >> because the previous r

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-11 Thread Lucas De Marchi
On Mon, Jan 11, 2021 at 10:13:15PM +0200, Jani Nikula wrote: On Fri, 08 Jan 2021, Matt Roper wrote: On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup wrote: TGL adds another level of indirection for applying WA based on stepping information rather than PCI REVID. So change TGL_REVID enum

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-11 Thread Aditya Swarup
On 1/11/21 12:57 PM, Matt Roper wrote: > On Mon, Jan 11, 2021 at 10:18:45PM +0200, Jani Nikula wrote: >> On Mon, 11 Jan 2021, Jani Nikula wrote: >>> On Fri, 08 Jan 2021, Matt Roper wrote: On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup wrote: > TGL adds another level of indirecti

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-11 Thread Lucas De Marchi
On Mon, Jan 11, 2021 at 12:57:43PM -0800, Matt Roper wrote: On Mon, Jan 11, 2021 at 10:18:45PM +0200, Jani Nikula wrote: On Mon, 11 Jan 2021, Jani Nikula wrote: > On Fri, 08 Jan 2021, Matt Roper wrote: >> On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup wrote: >>> TGL adds another level

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-11 Thread Matt Roper
On Mon, Jan 11, 2021 at 10:18:45PM +0200, Jani Nikula wrote: > On Mon, 11 Jan 2021, Jani Nikula wrote: > > On Fri, 08 Jan 2021, Matt Roper wrote: > >> On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup wrote: > >>> TGL adds another level of indirection for applying WA based on stepping > >>>

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-11 Thread Aditya Swarup
On 1/11/21 12:13 PM, Jani Nikula wrote: > On Fri, 08 Jan 2021, Matt Roper wrote: >> On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup wrote: >>> TGL adds another level of indirection for applying WA based on stepping >>> information rather than PCI REVID. So change TGL_REVID enum into >>> st

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-11 Thread Jani Nikula
On Mon, 11 Jan 2021, Jani Nikula wrote: > On Fri, 08 Jan 2021, Matt Roper wrote: >> On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup wrote: >>> TGL adds another level of indirection for applying WA based on stepping >>> information rather than PCI REVID. So change TGL_REVID enum into >>> s

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-11 Thread Jani Nikula
On Fri, 08 Jan 2021, Matt Roper wrote: > On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup wrote: >> TGL adds another level of indirection for applying WA based on stepping >> information rather than PCI REVID. So change TGL_REVID enum into >> stepping enum and use PCI REVID as index into re

[Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-11 Thread Aditya Swarup
TGL adds another level of indirection for applying WA based on stepping information rather than PCI REVID. So change TGL_REVID enum into stepping enum and use PCI REVID as index into revid to stepping table to fetch correct display and GT stepping for application of WAs as suggested by Matt Roper.

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-08 Thread Matt Roper
On Fri, Jan 08, 2021 at 03:18:52PM -0800, Aditya Swarup wrote: > TGL adds another level of indirection for applying WA based on stepping > information rather than PCI REVID. So change TGL_REVID enum into > stepping enum and use PCI REVID as index into revid to stepping table to > fetch correct disp

[Intel-gfx] [PATCH 1/2] drm/i915/tgl: Use TGL stepping info for applying WAs

2021-01-08 Thread Aditya Swarup
TGL adds another level of indirection for applying WA based on stepping information rather than PCI REVID. So change TGL_REVID enum into stepping enum and use PCI REVID as index into revid to stepping table to fetch correct display and GT stepping for application of WAs as suggested by Matt Roper.