Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()

2018-08-27 Thread Pandiyan, Dhinakaran
On Mon, 2018-08-27 at 14:56 +0300, Ville Syrjälä wrote: > On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote: > > skl_plane_has_planar is hard to read, simplify the logic by > > checking for > > support in the order of platform, pipe and plane. > > I had a slightly different

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()

2018-08-27 Thread Ville Syrjälä
On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote: > skl_plane_has_planar is hard to read, simplify the logic by checking for > support in the order of platform, pipe and plane. I had a slightly different version of this somewhere. But this one might be even better. > > No

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()

2018-08-24 Thread Pandiyan, Dhinakaran
On Fri, 2018-08-24 at 16:16 -0700, Rodrigo Vivi wrote: > On Fri, Aug 24, 2018 at 10:27:09PM +, Pandiyan, Dhinakaran wrote: > > > > > > On Fri, 2018-08-24 at 15:15 -0700, Rodrigo Vivi wrote: > > > On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan > > > wrote: > > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()

2018-08-24 Thread Rodrigo Vivi
On Fri, Aug 24, 2018 at 10:27:09PM +, Pandiyan, Dhinakaran wrote: > > > On Fri, 2018-08-24 at 15:15 -0700, Rodrigo Vivi wrote: > > On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote: > > > skl_plane_has_planar is hard to read, simplify the logic by > > > checking for > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()

2018-08-24 Thread Pandiyan, Dhinakaran
On Fri, 2018-08-24 at 15:15 -0700, Rodrigo Vivi wrote: > On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote: > > skl_plane_has_planar is hard to read, simplify the logic by > > checking for > > support in the order of platform, pipe and plane. > > > > No change in functionality

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()

2018-08-24 Thread Rodrigo Vivi
On Fri, Aug 24, 2018 at 01:38:55PM -0700, Dhinakaran Pandiyan wrote: > skl_plane_has_planar is hard to read, simplify the logic by checking for > support in the order of platform, pipe and plane. > > No change in functionality intended. > > Cc: Ville Syrjälä > Signed-off-by: Dhinakaran Pandiyan

[Intel-gfx] [PATCH 1/2] drm/i915: Clean up skl_plane_has_planar()

2018-08-24 Thread Dhinakaran Pandiyan
skl_plane_has_planar is hard to read, simplify the logic by checking for support in the order of platform, pipe and plane. No change in functionality intended. Cc: Ville Syrjälä Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_display.c | 27 +-- 1