Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disable -Woverride-init

2017-10-13 Thread Chris Wilson
Quoting Ville Syrjälä (2017-10-13 17:47:25) > On Fri, Oct 13, 2017 at 05:08:29PM +0100, Chris Wilson wrote: > > We commonly use an inheritance style approach to device parameters, > > where later generations inherit the defaults from earlier generations > > and then override settings that change. F

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disable -Woverride-init

2017-10-13 Thread Ville Syrjälä
On Fri, Oct 13, 2017 at 05:08:29PM +0100, Chris Wilson wrote: > We commonly use an inheritance style approach to device parameters, > where later generations inherit the defaults from earlier generations > and then override settings that change. For example, in i915_pci.c > BDW_FEATURES pulls in HS

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disable -Woverride-init

2017-10-13 Thread Michal Wajdeczko
On Fri, 13 Oct 2017 18:08:29 +0200, Chris Wilson wrote: We commonly use an inheritance style approach to device parameters, where later generations inherit the defaults from earlier generations and then override settings that change. For example, in i915_pci.c BDW_FEATURES pulls in HSW_FEATUR

[Intel-gfx] [PATCH 1/2] drm/i915: Disable -Woverride-init

2017-10-13 Thread Chris Wilson
We commonly use an inheritance style approach to device parameters, where later generations inherit the defaults from earlier generations and then override settings that change. For example, in i915_pci.c BDW_FEATURES pulls in HSW_FEATURES, makes a few changes for 48bit contexts and then individual

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disable -Woverride-init

2017-01-23 Thread Joonas Lahtinen
On ke, 2017-01-18 at 16:27 +, Chris Wilson wrote: > On Wed, Jan 18, 2017 at 05:56:13PM +0200, Joonas Lahtinen wrote: > > > > On ke, 2017-01-18 at 12:18 +, Chris Wilson wrote: > > > > > > -subdir-ccflags-$(CONFIG_DRM_I915_WERROR) := -Werror > > > +subdir-ccflags-y := -Wno-override-init # us

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disable -Woverride-init

2017-01-18 Thread Chris Wilson
On Wed, Jan 18, 2017 at 05:56:13PM +0200, Joonas Lahtinen wrote: > On ke, 2017-01-18 at 12:18 +, Chris Wilson wrote: > > We commonly use an inheritance style approach to device parameters, > > where later generations inherit the defaults from earlier generations > > and then override settings t

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disable -Woverride-init

2017-01-18 Thread Joonas Lahtinen
On ke, 2017-01-18 at 12:18 +, Chris Wilson wrote: > We commonly use an inheritance style approach to device parameters, > where later generations inherit the defaults from earlier generations > and then override settings that change. For example, in i915_pci.c > BDW_FEATURES pulls in HSW_FEATUR

[Intel-gfx] [PATCH 1/2] drm/i915: Disable -Woverride-init

2017-01-18 Thread Chris Wilson
We commonly use an inheritance style approach to device parameters, where later generations inherit the defaults from earlier generations and then override settings that change. For example, in i915_pci.c BDW_FEATURES pulls in HSW_FEATURES, makes a few changes for 48bit contexts and then individual