Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-17 Thread Jani Nikula
On Tue, 17 Nov 2015, Ville Syrjälä wrote: > On Tue, Nov 17, 2015 at 01:04:21PM +0200, Ville Syrjälä wrote: >> On Tue, Nov 17, 2015 at 10:47:06AM +0100, Daniel Vetter wrote: >> > On Wed, Nov 11, 2015 at 07:11:28PM +0200, ville.syrj...@linux.intel.com >> > wrote: >> > > From: Ville Syrjälä >> > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-17 Thread Ville Syrjälä
On Tue, Nov 17, 2015 at 01:04:21PM +0200, Ville Syrjälä wrote: > On Tue, Nov 17, 2015 at 10:47:06AM +0100, Daniel Vetter wrote: > > On Wed, Nov 11, 2015 at 07:11:28PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > We try to convert the old way of of specify

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-17 Thread Ville Syrjälä
On Tue, Nov 17, 2015 at 10:47:06AM +0100, Daniel Vetter wrote: > On Wed, Nov 11, 2015 at 07:11:28PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We try to convert the old way of of specifying fb tiling (obj->tiling) > > into the new fb modifiers. We store the result

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-17 Thread Daniel Vetter
On Wed, Nov 11, 2015 at 07:11:28PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We try to convert the old way of of specifying fb tiling (obj->tiling) > into the new fb modifiers. We store the result in the passed in mode_cmd > structure. But that structure comes directly

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-11 Thread Chris Wilson
On Wed, Nov 11, 2015 at 07:24:40PM +0200, Ville Syrjälä wrote: > On Wed, Nov 11, 2015 at 05:20:10PM +, Chris Wilson wrote: > > On Wed, Nov 11, 2015 at 07:11:28PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > We try to convert the old way of of specifyi

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-11 Thread Ville Syrjälä
On Wed, Nov 11, 2015 at 05:20:10PM +, Chris Wilson wrote: > On Wed, Nov 11, 2015 at 07:11:28PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We try to convert the old way of of specifying fb tiling (obj->tiling) > > into the new fb modifiers. We store the result

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-11 Thread Chris Wilson
On Wed, Nov 11, 2015 at 07:11:28PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We try to convert the old way of of specifying fb tiling (obj->tiling) > into the new fb modifiers. We store the result in the passed in mode_cmd > structure. But that structure comes directly

[Intel-gfx] [PATCH 1/2] drm/i915: Don't clobber the addfb2 ioctl params

2015-11-11 Thread ville . syrjala
From: Ville Syrjälä We try to convert the old way of of specifying fb tiling (obj->tiling) into the new fb modifiers. We store the result in the passed in mode_cmd structure. But that structure comes directly from the addfb2 ioctl, and gets copied back out to userspace, which means we're clobberi