Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-06 Thread Daniel Vetter
On Thu, Mar 05, 2015 at 03:07:52PM +, Tvrtko Ursulin wrote: > > On 03/04/2015 05:42 PM, Matt Roper wrote: > >On Wed, Mar 04, 2015 at 05:26:36PM +, Tvrtko Ursulin wrote: > >> > >>On 03/04/2015 02:15 AM, Matt Roper wrote: > >>>Universal planes allow us to have an active CRTC without a primar

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-05 Thread Tvrtko Ursulin
On 03/04/2015 05:42 PM, Matt Roper wrote: On Wed, Mar 04, 2015 at 05:26:36PM +, Tvrtko Ursulin wrote: On 03/04/2015 02:15 AM, Matt Roper wrote: Universal planes allow us to have an active CRTC without a primary plane framebuffer bound. Drop the test for primary->fb from intel_crtc_active

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-05 Thread Ville Syrjälä
On Thu, Mar 05, 2015 at 01:20:17PM +0100, Daniel Vetter wrote: > On Wed, Mar 04, 2015 at 08:21:16PM +0200, Ville Syrjälä wrote: > > On Wed, Mar 04, 2015 at 05:13:07PM +0100, Daniel Vetter wrote: > > > On Wed, Mar 04, 2015 at 11:45:42AM +0200, Ville Syrjälä wrote: > > > > On Tue, Mar 03, 2015 at 06:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-05 Thread Daniel Vetter
On Wed, Mar 04, 2015 at 08:21:16PM +0200, Ville Syrjälä wrote: > On Wed, Mar 04, 2015 at 05:13:07PM +0100, Daniel Vetter wrote: > > On Wed, Mar 04, 2015 at 11:45:42AM +0200, Ville Syrjälä wrote: > > > On Tue, Mar 03, 2015 at 06:15:12PM -0800, Matt Roper wrote: > > > > Universal planes allow us to h

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-04 Thread Ville Syrjälä
On Wed, Mar 04, 2015 at 05:13:07PM +0100, Daniel Vetter wrote: > On Wed, Mar 04, 2015 at 11:45:42AM +0200, Ville Syrjälä wrote: > > On Tue, Mar 03, 2015 at 06:15:12PM -0800, Matt Roper wrote: > > > Universal planes allow us to have an active CRTC without a primary plane > > > framebuffer bound. Dr

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-04 Thread Matt Roper
On Wed, Mar 04, 2015 at 05:26:36PM +, Tvrtko Ursulin wrote: > > On 03/04/2015 02:15 AM, Matt Roper wrote: > >Universal planes allow us to have an active CRTC without a primary plane > >framebuffer bound. Drop the test for primary->fb from > >intel_crtc_active() since we can clearly have activ

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-04 Thread Tvrtko Ursulin
On 03/04/2015 02:15 AM, Matt Roper wrote: Universal planes allow us to have an active CRTC without a primary plane framebuffer bound. Drop the test for primary->fb from intel_crtc_active() since we can clearly have active CRTC's without a framebuffer, and this check is now interfering with wate

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-04 Thread Daniel Vetter
On Tue, Mar 03, 2015 at 06:15:12PM -0800, Matt Roper wrote: > Universal planes allow us to have an active CRTC without a primary plane > framebuffer bound. Drop the test for primary->fb from > intel_crtc_active() since we can clearly have active CRTC's without a > framebuffer, and this check is no

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-04 Thread Daniel Vetter
On Wed, Mar 04, 2015 at 11:45:42AM +0200, Ville Syrjälä wrote: > On Tue, Mar 03, 2015 at 06:15:12PM -0800, Matt Roper wrote: > > Universal planes allow us to have an active CRTC without a primary plane > > framebuffer bound. Drop the test for primary->fb from > > intel_crtc_active() since we can c

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-04 Thread Ville Syrjälä
On Tue, Mar 03, 2015 at 06:15:12PM -0800, Matt Roper wrote: > Universal planes allow us to have an active CRTC without a primary plane > framebuffer bound. Drop the test for primary->fb from > intel_crtc_active() since we can clearly have active CRTC's without a > framebuffer, and this check is no

[Intel-gfx] [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active()

2015-03-03 Thread Matt Roper
Universal planes allow us to have an active CRTC without a primary plane framebuffer bound. Drop the test for primary->fb from intel_crtc_active() since we can clearly have active CRTC's without a framebuffer, and this check is now interfering with watermark calculations when we try to re-enable t