Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-05 Thread Matt Roper
On Thu, May 05, 2022 at 12:02:45PM +0100, Tvrtko Ursulin wrote: > > On 04/05/2022 19:17, Matt Roper wrote: > > On Wed, May 04, 2022 at 06:59:32PM +0100, Tvrtko Ursulin wrote: > > > > > > On 04/05/2022 17:48, Matt Roper wrote: > > > > On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-05 Thread Tvrtko Ursulin
On 04/05/2022 19:17, Matt Roper wrote: On Wed, May 04, 2022 at 06:59:32PM +0100, Tvrtko Ursulin wrote: On 04/05/2022 17:48, Matt Roper wrote: On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Matt Roper
On Wed, May 04, 2022 at 06:59:32PM +0100, Tvrtko Ursulin wrote: > > On 04/05/2022 17:48, Matt Roper wrote: > > On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Tvrtko Ursulin
On 04/05/2022 17:48, Matt Roper wrote: On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Matt Roper
On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed > to exercise a certain code path, so in case of values coming from MMIO > reads we cannot be sure CI will have all the possible

[Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be sure CI will have all the possible SKUs and parts. Use drm_warn instead and move logging to init phase while