Re: [Intel-gfx] [PATCH 1/2] drm/i915: Drop WARN_ON(flags) from ppgtt_bind_vma()

2014-03-22 Thread Ben Widawsky
On Wed, Mar 12, 2014 at 07:32:26PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We will call ppgtt_bind_vma() with flags != 0, so the WARN_ON(flags) is bogus. Kill it. This is not an appropriate commit message to change an invariant. The

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Drop WARN_ON(flags) from ppgtt_bind_vma()

2014-03-22 Thread Daniel Vetter
On Sat, Mar 22, 2014 at 09:59:50AM -0700, Ben Widawsky wrote: On Wed, Mar 12, 2014 at 07:32:26PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We will call ppgtt_bind_vma() with flags != 0, so the WARN_ON(flags) is bogus. Kill it.

[Intel-gfx] [PATCH 1/2] drm/i915: Drop WARN_ON(flags) from ppgtt_bind_vma()

2014-03-12 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com We will call ppgtt_bind_vma() with flags != 0, so the WARN_ON(flags) is bogus. Kill it. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 -- 1 file changed, 2 deletions(-) diff --git