Re: [Intel-gfx] [PATCH 1/2] drm/i915: Encapsulate kconfig constant values inside boolean predicates

2019-10-25 Thread Nathan Chancellor
On Fri, Oct 25, 2019 at 02:59:42PM +0100, Chris Wilson wrote: > Avoid angering clang and smatch by using a constant value in a '&&' test, > by forcing that constant value into a boolean. > > E.g., > drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:159:13: warning: use of > logical '&&' with

[Intel-gfx] [PATCH 1/2] drm/i915: Encapsulate kconfig constant values inside boolean predicates

2019-10-25 Thread Chris Wilson
Avoid angering clang and smatch by using a constant value in a '&&' test, by forcing that constant value into a boolean. E.g., drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:159:13: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] if (!delay &&