Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make the device_info structure __initconst

2014-07-10 Thread Daniel Vetter
On Thu, Jul 10, 2014 at 10:47:21PM +0100, Damien Lespiau wrote: > On Thu, Jul 10, 2014 at 10:25:27PM +0200, Daniel Vetter wrote: > > On Thu, Jul 10, 2014 at 02:52:42PM +0100, Damien Lespiau wrote: > > > We don't need them past the module initialization as the correct > > > structure is copied into

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make the device_info structure __initconst

2014-07-10 Thread Damien Lespiau
On Thu, Jul 10, 2014 at 10:25:27PM +0200, Daniel Vetter wrote: > On Thu, Jul 10, 2014 at 02:52:42PM +0100, Damien Lespiau wrote: > > We don't need them past the module initialization as the correct > > structure is copied into dev_priv in ->load(), called from > > drm_pci_init(), called from the mo

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make the device_info structure __initconst

2014-07-10 Thread Daniel Vetter
On Thu, Jul 10, 2014 at 02:52:42PM +0100, Damien Lespiau wrote: > We don't need them past the module initialization as the correct > structure is copied into dev_priv in ->load(), called from > drm_pci_init(), called from the module init funtion. > > I'm always hesitant about adding new members to

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make the device_info structure __initconst

2014-07-10 Thread Paulo Zanoni
2014-07-10 10:52 GMT-03:00 Damien Lespiau : > We don't need them past the module initialization as the correct > structure is copied into dev_priv in ->load(), called from > drm_pci_init(), called from the module init funtion. > > I'm always hesitant about adding new members to struct intel_device_

[Intel-gfx] [PATCH 1/2] drm/i915: Make the device_info structure __initconst

2014-07-10 Thread Damien Lespiau
We don't need them past the module initialization as the correct structure is copied into dev_priv in ->load(), called from drm_pci_init(), called from the module init funtion. I'm always hesitant about adding new members to struct intel_device_info because it will add 30+ * sizeof(member) bytes t