Re: [Intel-gfx] [PATCH 1/2] drm/i915: Split uncore init into vfunc setup and mmio setup

2017-10-09 Thread Chris Wilson
Quoting Joonas Lahtinen (2017-10-09 10:19:40) > On Sat, 2017-10-07 at 16:28 +0100, Chris Wilson wrote: > > Quoting Michal Wajdeczko (2017-10-07 12:14:30) > > > On Sat, 07 Oct 2017 10:56:58 +0200, Chris Wilson > > > > +void intel_uncore_init_mmio(struct drm_i915_private *dev_priv) > > > > +{ > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Split uncore init into vfunc setup and mmio setup

2017-10-09 Thread Joonas Lahtinen
On Sat, 2017-10-07 at 16:28 +0100, Chris Wilson wrote: > Quoting Michal Wajdeczko (2017-10-07 12:14:30) > > On Sat, 07 Oct 2017 10:56:58 +0200, Chris Wilson > > > +void intel_uncore_init_mmio(struct drm_i915_private *dev_priv) > > > +{ > > > + i915_check_vgpu(dev_priv); > > > + > > > +

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Split uncore init into vfunc setup and mmio setup

2017-10-07 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-07 12:14:30) > On Sat, 07 Oct 2017 10:56:58 +0200, Chris Wilson > > +void intel_uncore_init_mmio(struct drm_i915_private *dev_priv) > > +{ > > + i915_check_vgpu(dev_priv); > > + > > + intel_uncore_edram_detect(dev_priv); > > +

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Split uncore init into vfunc setup and mmio setup

2017-10-07 Thread Michal Wajdeczko
On Sat, 07 Oct 2017 10:56:58 +0200, Chris Wilson wrote: Some early initialisation functions (like intel_uc_init_early) would like to access the table of mmio registers sorted by their powerwell, which is currently setup later in intel_uncore_init(). Since this is a

[Intel-gfx] [PATCH 1/2] drm/i915: Split uncore init into vfunc setup and mmio setup

2017-10-07 Thread Chris Wilson
Some early initialisation functions (like intel_uc_init_early) would like to access the table of mmio registers sorted by their powerwell, which is currently setup later in intel_uncore_init(). Since this is a static table that now doesn't touch hw, once upon a time we needed to probe ivb to