Re: [Intel-gfx] [PATCH 1/2] drm/i915: Tidy the tail of i915_tiling_ok()

2017-02-03 Thread Tvrtko Ursulin
On 03/02/2017 11:50, Chris Wilson wrote: The current tail breaks the pattern of if (check) return false, which can catch the reader out. If we move the gen2/3 power-of-two test into the earlier gen2/3 branch, we can eliminate the contrary tail. Suggested-by: Tvrtko Ursulin Signed-off-by: Chris

[Intel-gfx] [PATCH 1/2] drm/i915: Tidy the tail of i915_tiling_ok()

2017-02-03 Thread Chris Wilson
The current tail breaks the pattern of if (check) return false, which can catch the reader out. If we move the gen2/3 power-of-two test into the earlier gen2/3 branch, we can eliminate the contrary tail. Suggested-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gp