Re: [Intel-gfx] [PATCH 1/2] drm/i915: report Gen5+ CPU and PCH FIFO underruns

2013-04-19 Thread Daniel Vetter
On Thu, Apr 18, 2013 at 11:29:17PM +0300, Imre Deak wrote: > On Fri, 2013-04-12 at 17:57 -0300, Paulo Zanoni wrote: > > +static void cpt_set_fifo_underrun_reporting(struct drm_device *dev, > > + enum transcoder pch_transcoder, > > +

Re: [Intel-gfx] [PATCH 1/2] drm/i915: report Gen5+ CPU and PCH FIFO underruns

2013-04-18 Thread Imre Deak
Hi, one comment below: On Fri, 2013-04-12 at 17:57 -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > In this commit we enable both CPU and PCH FIFO underrun reporting and > start reporting them. We follow a few rules: > - after we receive one of these errors, we mask the interrupt, so >

[Intel-gfx] [PATCH 1/2] drm/i915: report Gen5+ CPU and PCH FIFO underruns

2013-04-12 Thread Paulo Zanoni
From: Paulo Zanoni In this commit we enable both CPU and PCH FIFO underrun reporting and start reporting them. We follow a few rules: - after we receive one of these errors, we mask the interrupt, so we won't get an "interrupt storm" and we also won't flood dmesg; - at each mode set we en