Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-16 Thread Chris Wilson
On Mon, May 12, 2014 at 06:40:43PM +0200, Daniel Vetter wrote: I think as soon as we have the golden context stuff from Mika we could drop our usage of restore_inhibit. We only need that to avoid the hw getting angry if the context state is illegal afaik. Apart from the contexts being over

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-16 Thread Daniel Vetter
On Fri, May 16, 2014 at 12:36:09PM +0100, Chris Wilson wrote: On Mon, May 12, 2014 at 06:40:43PM +0200, Daniel Vetter wrote: I think as soon as we have the golden context stuff from Mika we could drop our usage of restore_inhibit. We only need that to avoid the hw getting angry if the

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-16 Thread Chris Wilson
On Fri, May 16, 2014 at 04:27:34PM +0200, Daniel Vetter wrote: On Fri, May 16, 2014 at 12:36:09PM +0100, Chris Wilson wrote: On Mon, May 12, 2014 at 06:40:43PM +0200, Daniel Vetter wrote: I think as soon as we have the golden context stuff from Mika we could drop our usage of

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-16 Thread Daniel Vetter
On Fri, May 16, 2014 at 03:45:24PM +0100, Chris Wilson wrote: On Fri, May 16, 2014 at 04:27:34PM +0200, Daniel Vetter wrote: On Fri, May 16, 2014 at 12:36:09PM +0100, Chris Wilson wrote: On Mon, May 12, 2014 at 06:40:43PM +0200, Daniel Vetter wrote: I think as soon as we have the golden

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-12 Thread Daniel Vetter
On Thu, May 08, 2014 at 01:18:40PM +0300, Ville Syrjälä wrote: On Thu, May 08, 2014 at 12:54:47PM +0300, Ville Syrjälä wrote: On Wed, May 07, 2014 at 11:59:23PM +0300, Abdiel Janulgue wrote: On Wednesday, May 07, 2014 02:49:31 PM Ville Syrjälä wrote: I quickly cobbled together a hsw

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-08 Thread Ville Syrjälä
On Wed, May 07, 2014 at 11:59:23PM +0300, Abdiel Janulgue wrote: On Wednesday, May 07, 2014 02:49:31 PM Ville Syrjälä wrote: I quickly cobbled together a hsw version of this and gave it a whirl on one machine. Seems to work just fine here, and no lockups when switching between hw and sw

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-08 Thread Ville Syrjälä
On Thu, May 08, 2014 at 12:54:47PM +0300, Ville Syrjälä wrote: On Wed, May 07, 2014 at 11:59:23PM +0300, Abdiel Janulgue wrote: On Wednesday, May 07, 2014 02:49:31 PM Ville Syrjälä wrote: I quickly cobbled together a hsw version of this and gave it a whirl on one machine. Seems to work

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-07 Thread Ville Syrjälä
I quickly cobbled together a hsw version of this and gave it a whirl on one machine. Seems to work just fine here, and no lockups when switching between hw and sw binding tables. Did you get the lockups on hsw even with rendercopy? Here's my hsw version: From

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-07 Thread Chris Wilson
On Wed, May 07, 2014 at 02:49:31PM +0300, Ville Syrjälä wrote: I quickly cobbled together a hsw version of this and gave it a whirl on one machine. Seems to work just fine here, and no lockups when switching between hw and sw binding tables. Did you get the lockups on hsw even with rendercopy?

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-07 Thread Abdiel Janulgue
On Wednesday, May 07, 2014 02:49:31 PM Ville Syrjälä wrote: I quickly cobbled together a hsw version of this and gave it a whirl on one machine. Seems to work just fine here, and no lockups when switching between hw and sw binding tables. Did you get the lockups on hsw even with rendercopy?

[Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-06 Thread Abdiel Janulgue
Use on-chip hw-binding table generator to generate binding tables when the test emits SURFACE_STATES packets. The hw generates these binding table packets internally so we don't have to allocate space on the batchbuffer. Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com ---

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-06 Thread Ville Syrjälä
On Tue, May 06, 2014 at 10:48:02PM +0300, Abdiel Janulgue wrote: Use on-chip hw-binding table generator to generate binding tables when the test emits SURFACE_STATES packets. The hw generates these binding table packets internally so we don't have to allocate space on the batchbuffer.

Re: [Intel-gfx] [PATCH 1/2] rendercopy/bdw: Enable hw-generated binding tables

2014-05-06 Thread Abdiel Janulgue
On Wednesday, May 07, 2014 12:38:04 AM Ville Syrjälä wrote: On Tue, May 06, 2014 at 10:48:02PM +0300, Abdiel Janulgue wrote: Use on-chip hw-binding table generator to generate binding tables when the test emits SURFACE_STATES packets. The hw generates these binding table packets internally