Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

2022-07-08 Thread Karolina Drobnik
Hi Andi, On 08.07.2022 13:38, Andi Shyti wrote: Hi Karolina, [...] + dma_resv_for_each_fence_unlocked(&cursor, fence) { + if (dma_fence_is_i915(fence) && + !i915_request_started(to_request(fence))) + intel_rps_boost(to_request(fence)

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

2022-07-08 Thread Andi Shyti
Hi Karolina, [...] > > > > + dma_resv_for_each_fence_unlocked(&cursor, fence) { > > > > + if (dma_fence_is_i915(fence) && > > > > + !i915_request_started(to_request(fence))) > > > > + intel_rps_boost(to_request(fence)); > > > > + }

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

2022-07-08 Thread Karolina Drobnik
Hi Rodrigo and Andi, Thank you very much for your reviews. On 07.07.2022 23:50, Andi Shyti wrote: Hi Rodrigo, Chris and Karolina, On Thu, Jul 07, 2022 at 01:57:52PM -0400, Rodrigo Vivi wrote: On Tue, Jul 05, 2022 at 12:57:17PM +0200, Karolina Drobnik wrote: From: Chris Wilson We employ a "

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

2022-07-07 Thread Andi Shyti
Hi Rodrigo, Chris and Karolina, On Thu, Jul 07, 2022 at 01:57:52PM -0400, Rodrigo Vivi wrote: > On Tue, Jul 05, 2022 at 12:57:17PM +0200, Karolina Drobnik wrote: > > From: Chris Wilson > > > > We employ a "waitboost" heuristic to detect when userspace is stalled > > waiting for results from earl

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

2022-07-07 Thread Rodrigo Vivi
On Tue, Jul 05, 2022 at 12:57:17PM +0200, Karolina Drobnik wrote: > From: Chris Wilson > > We employ a "waitboost" heuristic to detect when userspace is stalled > waiting for results from earlier execution. Under latency sensitive work > mixed between the gpu/cpu, the GPU is typically under-utili

[Intel-gfx] [PATCH 1/3] drm/i915/gem: Look for waitboosting across the whole object prior to individual waits

2022-07-05 Thread Karolina Drobnik
From: Chris Wilson We employ a "waitboost" heuristic to detect when userspace is stalled waiting for results from earlier execution. Under latency sensitive work mixed between the gpu/cpu, the GPU is typically under-utilised and so RPS sees that low utilisation as a reason to downclock the freque