Re: [Intel-gfx] [PATCH 1/3] drm/i915/gtt: Split gen8_ppgtt_clear_pte_range

2016-10-04 Thread Joonas Lahtinen
I wonder if GCC is doing the right thing, do we have some benchmark for this, Chris, Mika? The code is much more readable in my eyes after the changes. On ti, 2016-10-04 at 15:54 +0200, Michał Winiarski wrote: > +static void gen8_ppgtt_clear_pt(struct i915_address_space *vm, > +

[Intel-gfx] [PATCH 1/3] drm/i915/gtt: Split gen8_ppgtt_clear_pte_range

2016-10-04 Thread Michał Winiarski
Let's use more top-down approach, where each gen8_ppgtt_clear_* function is responsible for clearing the struct passed as an argument and calling relevant clear_range functions on lower-level tables. Doing this rather than operating on PTE ranges makes the implementation of shrinking page tables