Re: [Intel-gfx] [PATCH 1/3] drm/i915/perf: Subtract gtt_offset from hw_tail

2023-09-12 Thread Dixit, Ashutosh
On Tue, 12 Sep 2023 18:25:16 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > On Fri, Sep 08, 2023 at 06:16:24PM -0700, Ashutosh Dixit wrote: > > The code in oa_buffer_check_unlocked() is correct only if the OA buffer is > > 16 MB aligned (which seems to be the case today in i915). However when

Re: [Intel-gfx] [PATCH 1/3] drm/i915/perf: Subtract gtt_offset from hw_tail

2023-09-12 Thread Umesh Nerlige Ramappa
On Fri, Sep 08, 2023 at 06:16:24PM -0700, Ashutosh Dixit wrote: The code in oa_buffer_check_unlocked() is correct only if the OA buffer is 16 MB aligned (which seems to be the case today in i915). However when the 16 MB alignment is dropped, when we "Subtract partial amount off the tail", the "&

[Intel-gfx] [PATCH 1/3] drm/i915/perf: Subtract gtt_offset from hw_tail

2023-09-08 Thread Ashutosh Dixit
The code in oa_buffer_check_unlocked() is correct only if the OA buffer is 16 MB aligned (which seems to be the case today in i915). However when the 16 MB alignment is dropped, when we "Subtract partial amount off the tail", the "& (OA_BUFFER_SIZE - 1)" operation in OA_TAKEN() will result in an