Re: [Intel-gfx] [PATCH 1/3] drm/i915/uc: Extract common code from GuC stop/disable comm

2019-08-28 Thread Daniele Ceraolo Spurio
BTW, this patch should be enough for https://bugs.freedesktop.org/show_bug.cgi?id=110943, because we disable interrupts on _stop and therefore we don't leave them enabled even if we skip fini_hw (which still needs to be fixed for the submission side of things). Daniele On 8/28/19 1:47 PM, Da

Re: [Intel-gfx] [PATCH 1/3] drm/i915/uc: Extract common code from GuC stop/disable comm

2019-08-28 Thread Daniele Ceraolo Spurio
On 8/27/19 5:45 PM, Fernando Pacheco wrote: During normal driver unload we attempt to disable GuC communication while it is currently stopped. This results in a nop'd call to intel_guc_ct_disable within guc_disable_communication because stop/disable rely on the same flag to prevent further comm

[Intel-gfx] [PATCH 1/3] drm/i915/uc: Extract common code from GuC stop/disable comm

2019-08-27 Thread Fernando Pacheco
During normal driver unload we attempt to disable GuC communication while it is currently stopped. This results in a nop'd call to intel_guc_ct_disable within guc_disable_communication because stop/disable rely on the same flag to prevent further comms with CT. We can avoid the call to disable and