[Intel-gfx] [PATCH 1/3] drm/i915: Protect the argument expansion in LRI and SRM macros

2014-04-07 Thread Damien Lespiau
It seems like it wouldn't be too unlikely to be wanting to use a an expression in the macro argument and things could go very wrong. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Protect the argument expansion in LRI and SRM macros

2014-04-07 Thread Ben Widawsky
On Mon, Apr 07, 2014 at 08:24:32PM +0100, Damien Lespiau wrote: > It seems like it wouldn't be too unlikely to be wanting to use a an > expression in the macro argument and things could go very wrong. > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_reg.h | 4 ++-- > 1 file ch

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Protect the argument expansion in LRI and SRM macros

2014-04-09 Thread Daniel Vetter
On Mon, Apr 07, 2014 at 01:47:05PM -0700, Ben Widawsky wrote: > On Mon, Apr 07, 2014 at 08:24:32PM +0100, Damien Lespiau wrote: > > It seems like it wouldn't be too unlikely to be wanting to use a an > > expression in the macro argument and things could go very wrong. > > > > Signed-off-by: Damien