[Intel-gfx] [PATCH 1/3] drm/i915: refactor the IRQ init/reset macros

2019-04-08 Thread Paulo Zanoni
The whole point of having macros here is for the token pasting necessary to automatically have IMR, IIR and IER selected. We don't really need or want all the inlining that happens as a consequence. The good thing about the current code is that it works regardless of the relative offsets between th

Re: [Intel-gfx] [PATCH 1/3] drm/i915: refactor the IRQ init/reset macros

2019-04-09 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 05:37:27PM -0700, Paulo Zanoni wrote: > The whole point of having macros here is for the token pasting > necessary to automatically have IMR, IIR and IER selected. We don't > really need or want all the inlining that happens as a consequence. > The good thing about the curre

Re: [Intel-gfx] [PATCH 1/3] drm/i915: refactor the IRQ init/reset macros

2019-04-10 Thread Paulo Zanoni
Em ter, 2019-04-09 às 21:10 +0300, Ville Syrjälä escreveu: > On Mon, Apr 08, 2019 at 05:37:27PM -0700, Paulo Zanoni wrote: > > The whole point of having macros here is for the token pasting > > necessary to automatically have IMR, IIR and IER selected. We don't > > really need or want all the inlin