Re: [Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2016-10-14 Thread Timo Aaltonen
On 14.08.2015 08:18, Zhang, Xiong Y wrote: >> On Mon, Aug 10, 2015 at 06:23:19PM +, Rodrigo Vivi wrote: >>> I believe this function could be added along with the next patch that >>> is the first to use it... >>> Or it would be good to have a good commit message explaining why this >>> function

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2015-08-13 Thread Zhang, Xiong Y
> On Mon, Aug 10, 2015 at 06:23:19PM +, Rodrigo Vivi wrote: > > I believe this function could be added along with the next patch that > > is the first to use it... > > Or it would be good to have a good commit message explaining why this > > function is needed and what is be used for... > > Ye

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2015-08-12 Thread Daniel Vetter
On Mon, Aug 10, 2015 at 06:23:19PM +, Rodrigo Vivi wrote: > I believe this function could be added along with the next patch that is > the first to use it... > Or it would be good to have a good commit message explaining why this > function is needed and what is be used for... Yes, please don'

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2015-08-10 Thread Rodrigo Vivi
I believe this function could be added along with the next patch that is the first to use it... Or it would be good to have a good commit message explaining why this function is needed and what is be used for... more bikeshedings inline: On Mon, Aug 10, 2015 at 12:39 AM Xiong Zhang wrote: > Sig

[Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2015-08-10 Thread Xiong Zhang
Signed-off-by: Xiong Zhang --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_panel.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 47cef0e..f57a0b4 100644 --- a/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 1/4] drm/i915: Adding intel_panel_scale_none() helper function

2015-08-10 Thread Xiong Zhang
From: dell Signed-off-by: Xiong Zhang --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_panel.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 47cef0e..f57a0b4 100644 --- a/driver