Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-17 Thread Daniel Vetter
On Thu, Jul 17, 2014 at 3:42 PM, Paulo Zanoni wrote: >> On Wed, Jul 16, 2014 at 06:19:13PM -0300, Paulo Zanoni wrote: >>> 2014-07-14 14:34 GMT-03:00 Daniel Vetter : >>> > On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: >>> >> 2014-07-07 18:53 GMT-03:00 Jesse Barnes : >>> >> > On Mon,

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-17 Thread Paulo Zanoni
2014-07-17 5:06 GMT-03:00 Daniel Vetter : > On Wed, Jul 16, 2014 at 06:19:13PM -0300, Paulo Zanoni wrote: >> 2014-07-14 14:34 GMT-03:00 Daniel Vetter : >> > On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: >> >> 2014-07-07 18:53 GMT-03:00 Jesse Barnes : >> >> > On Mon, 7 Jul 2014 18:48

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-17 Thread Daniel Vetter
On Wed, Jul 16, 2014 at 06:19:13PM -0300, Paulo Zanoni wrote: > 2014-07-14 14:34 GMT-03:00 Daniel Vetter : > > On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: > >> 2014-07-07 18:53 GMT-03:00 Jesse Barnes : > >> > On Mon, 7 Jul 2014 18:48:47 -0300 > >> > Paulo Zanoni wrote: > >> > > >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-16 Thread Paulo Zanoni
2014-07-14 14:34 GMT-03:00 Daniel Vetter : > On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: >> 2014-07-07 18:53 GMT-03:00 Jesse Barnes : >> > On Mon, 7 Jul 2014 18:48:47 -0300 >> > Paulo Zanoni wrote: >> > >> >> (documenting what we discussed on IRC) >> >> >> >> 2014-06-20 13:29 GMT

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 11:56:57AM -0300, Paulo Zanoni wrote: > 2014-07-07 18:53 GMT-03:00 Jesse Barnes : > > On Mon, 7 Jul 2014 18:48:47 -0300 > > Paulo Zanoni wrote: > > > >> (documenting what we discussed on IRC) > >> > >> 2014-06-20 13:29 GMT-03:00 Jesse Barnes : > >> > This was always the cas

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-14 Thread Paulo Zanoni
2014-07-07 18:53 GMT-03:00 Jesse Barnes : > On Mon, 7 Jul 2014 18:48:47 -0300 > Paulo Zanoni wrote: > >> (documenting what we discussed on IRC) >> >> 2014-06-20 13:29 GMT-03:00 Jesse Barnes : >> > This was always the case on our suspend path, but it was recently >> > exposed by the change to use o

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-07 Thread Jesse Barnes
On Mon, 7 Jul 2014 18:48:47 -0300 Paulo Zanoni wrote: > (documenting what we discussed on IRC) > > 2014-06-20 13:29 GMT-03:00 Jesse Barnes : > > This was always the case on our suspend path, but it was recently > > exposed by the change to use our runtime IRQ disable routine rather than > > the

Re: [Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-07-07 Thread Paulo Zanoni
(documenting what we discussed on IRC) 2014-06-20 13:29 GMT-03:00 Jesse Barnes : > This was always the case on our suspend path, but it was recently > exposed by the change to use our runtime IRQ disable routine rather than > the full DRM IRQ disable. Keep the warning on the enable side, as that

[Intel-gfx] [PATCH 1/4] drm/i915: don't warn if IRQs are disabled when shutting down display IRQs

2014-06-20 Thread Jesse Barnes
This was always the case on our suspend path, but it was recently exposed by the change to use our runtime IRQ disable routine rather than the full DRM IRQ disable. Keep the warning on the enable side, as that really would indicate a bug. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i91