[Intel-gfx] [PATCH 1/4] drm/i915: handle input/output sdvo timings separately in mode_set

2012-04-10 Thread Daniel Vetter
We seem to have a decent confusion between the output timings and the input timings of the sdvo encoder. If I understand the code correctly, we use the original mode unchanged for the output timings, safe for the lvds case. And we should use the adjusted mode for input timings. Clarify the

Re: [Intel-gfx] [PATCH 1/4] drm/i915: handle input/output sdvo timings separately in mode_set

2012-04-10 Thread Jesse Barnes
On Tue, 10 Apr 2012 13:55:46 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: We seem to have a decent confusion between the output timings and the input timings of the sdvo encoder. If I understand the code correctly, we use the original mode unchanged for the output timings, safe for the

Re: [Intel-gfx] [PATCH 1/4] drm/i915: handle input/output sdvo timings separately in mode_set

2012-04-10 Thread Daniel Vetter
On Tue, Apr 10, 2012 at 09:17:37AM -0700, Jesse Barnes wrote: On Tue, 10 Apr 2012 13:55:46 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: We seem to have a decent confusion between the output timings and the input timings of the sdvo encoder. If I understand the code correctly, we use

Re: [Intel-gfx] [PATCH 1/4] drm/i915: handle input/output sdvo timings separately in mode_set

2012-04-10 Thread Jesse Barnes
On Tue, 10 Apr 2012 18:36:49 +0200 Daniel Vetter dan...@ffwll.ch wrote: Well, neither do I have a clue about sdvo, but I think I somewhat self-consistent explanation for what's going on. Sdvo seems to have two timings, one is the output timing which will be sent over whatever is connected on