Re: [Intel-gfx] [PATCH 1/4] drm/i915: rip out intel_disable_pch_ports

2012-09-13 Thread Jesse Barnes
On Thu, 6 Sep 2012 22:08:32 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: Even with the old crtc helper code we should have disabled all encoders on that pipe by now, and with the new code this would definitely paper over a bug. We already have the necessary checks in place in

[Intel-gfx] [PATCH 1/4] drm/i915: rip out intel_disable_pch_ports

2012-09-06 Thread Daniel Vetter
Even with the old crtc helper code we should have disabled all encoders on that pipe by now, and with the new code this would definitely paper over a bug. We already have the necessary checks in place in intel_disable_transcoder, so if we accidentally leave a pch port on, this will be caught.